Skip to content
Snippets Groups Projects

Address SonarQube code smells

Merged JORGE SASIAIN requested to merge feature/NAT-356-sonarqube-code-smells into develop
All threads resolved!
Files
3
@@ -145,7 +145,7 @@ class NetboxClient:
@@ -145,7 +145,7 @@ class NetboxClient:
"""Create a new device in Netbox."""
"""Create a new device in Netbox."""
# Get device type id
# Get device type id
tier_info = TierInfo().get_module_by_name(f"Tier{site_tier}")
tier_info = TierInfo().get_module_by_name(f"tier{site_tier}")
device_type = self.netbox.dcim.device_types.get(model=tier_info.device_type)
device_type = self.netbox.dcim.device_types.get(model=tier_info.device_type)
# Get device role id
# Get device role id
@@ -261,7 +261,6 @@ class NetboxClient:
@@ -261,7 +261,6 @@ class NetboxClient:
):
):
interface.lag = None
interface.lag = None
interface.save()
interface.save()
return
def get_available_lags(self, router_id: UUID) -> list[str]:
def get_available_lags(self, router_id: UUID) -> list[str]:
"""Return all available :term:`LAG`s not assigned to a device."""
"""Return all available :term:`LAG`s not assigned to a device."""
Loading