Address SonarQube code smells

I fixed the ones I could. It was quick. I think it's pointless to try to fix https://sonarqube.software.geant.org/project/issues?branch=feature%2FNAT-356-sonarqube-code-smells&id=gso&open=AYvXVReaO1NWXaQ602V0&resolved=false because it's by design, but correct me if I'm wrong.

requested review from @neda.moeini

assigned to @jorge.sasiain

added 1 commit

• 1aef87b2 - Address SonarQube duplicated lines in create_site.py

Compare with previous version

added 35 commits

• 1aef87b2...f3fe9d06 - 33 commits from branch develop
• 36e9b343 - Address SonarQube code smells
• a07e02cc - Address SonarQube duplicated lines in create_site.py

Compare with previous version

added 2 commits

• 9b11b288 - NAT-356: create BaseSiteModel and extend it in CreateSiteForm
• effc2892 - NAT-356: extend BaseSiteModel it in SiteImportModel

Compare with previous version

added 10 commits

• effc2892...35817ba4 - 6 commits from branch develop
• 12dbf6d4 - Address SonarQube code smells
• 91e16db4 - Address SonarQube duplicated lines in create_site.py
• 1287ea49 - NAT-356: create BaseSiteModel and extend it in CreateSiteForm
• a45c877f - NAT-356: extend BaseSiteModel it in SiteImportModel

Compare with previous version

added 1 commit

• 96c56efd - NAT-356: fix tox issues

Compare with previous version

added 1 commit

• 875c0df0 - NAT-356: move BaseSiteValidatorModel to utils/helpers.py

Compare with previous version

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 875c0df0 succeeds

merged