Skip to content
Snippets Groups Projects

Address SonarQube code smells

Merged JORGE SASIAIN requested to merge feature/NAT-356-sonarqube-code-smells into develop
All threads resolved!
1 file
+ 1
3
Compare changes
  • Side-by-side
  • Inline
@@ -38,7 +38,6 @@ def initial_input_form_generator(product_name: str) -> FormGenerator: # noqa: C
@validator("site_ts_address", allow_reuse=True)
def validate_ts_address(cls, site_ts_address: str) -> str:
validate_site_fields_is_unique("site_ts_address", site_ts_address)
validate_ipv4_or_ipv6(site_ts_address)
return site_ts_address
@@ -47,7 +46,7 @@ def initial_input_form_generator(product_name: str) -> FormGenerator: # noqa: C
validate_country_code(country_code)
return country_code
@validator("site_internal_id", "site_bgp_community_id", allow_reuse=True)
@validator("site_ts_address", "site_internal_id", "site_bgp_community_id", "site_name", allow_reuse=True)
def validate_unique_fields(cls, value: str, field: ModelField) -> str | int:
return validate_site_fields_is_unique(field.name, value)
@@ -58,7 +57,6 @@ def initial_input_form_generator(product_name: str) -> FormGenerator: # noqa: C
The site name must consist of three uppercase letters (A-Z) followed
by an optional single digit (0-9).
"""
validate_site_fields_is_unique("site_name", site_name)
validate_site_name(site_name)
return site_name
Loading