resolve last linting errors

gso/api/__init__.py

 """Initialisation class for the :term:`GSO` :term:`API`."""
+
 from fastapi import APIRouter
 
 from gso.api.v1 import router as router_v1

gso/api/v1/__init__.py

 """Version 1 of the :term:`GSO` :term:`API`."""
+
 from fastapi import APIRouter
 
 from gso.api.v1.imports import router as imports_router

gso/api/v1/imports.py

 """:term:`GSO` :term:`API` endpoints that import different types of existing services."""
+
 import ipaddress
 from typing import Any
 from uuid import UUID

gso/api/v1/subscriptions.py

 """:term:`API` endpoint for fetching different types of subscriptions."""
+
 from typing import Any
 
 from fastapi import Depends, status

gso/cli/import_sites.py

 """:term:`CLI` command for importing sites."""
+
 import typer
 
 app: typer.Typer = typer.Typer()

gso/cli/netbox.py

 """A :term:`CLI` for interacting with Netbox."""
+
 import typer
 from pynetbox import RequestError
 

gso/products/__init__.py

@@ -4,6 +4,7 @@
    Whenever a new product type is added, this should be reflected in the :py:class:`gso.products.ProductType`
    enumerator.
 """
+
 from orchestrator.domain import SUBSCRIPTION_MODEL_REGISTRY
 from pydantic_forms.types import strEnum
 

gso/products/product_blocks/iptrunk.py

@@ -36,7 +36,7 @@ class IptrunkType(strEnum):
 T_co = TypeVar("T_co", covariant=True)
 
 
-class LAGMemberList(UniqueConstrainedList[T_co]):
+class LAGMemberList(UniqueConstrainedList[T_co]):  # type: ignore[type-var]
     """A list of :term:`LAG` member interfaces."""
 
 
@@ -66,7 +66,7 @@ class IptrunkInterfaceBlock(IptrunkInterfaceBlockProvisioning, lifecycle=[Subscr
     interface_description: str
 
 
-class IptrunkSides(UniqueConstrainedList[T_co]):
+class IptrunkSides(UniqueConstrainedList[T_co]):  # type: ignore[type-var]
     """A list of IP trunk interfaces that make up one side of a link."""
 
     min_items = 2

gso/products/product_blocks/router.py

 """Product block for :class:`Router` products."""
+
 import ipaddress
 
 from orchestrator.domain.base import ProductBlockModel

gso/products/product_blocks/site.py

 """The product block that describes a site subscription."""
+
 import re
 
 from orchestrator.domain.base import ProductBlockModel

gso/services/netbox_client.py

 """Contain all methods to communicate with the NetBox API endpoint. Data Center Infrastructure Main (DCIM)."""
+
 from uuid import UUID
 
 import pydantic

gso/services/provisioning_proxy.py

@@ -2,6 +2,7 @@
 
 :term:`LSO` is responsible for executing Ansible playbooks, that deploy subscriptions.
 """
+
 import json
 import logging
 from functools import partial

gso/utils/helpers.py

@@ -213,7 +213,7 @@ def validate_site_name(site_name: str) -> str:
     if not pattern.match(site_name):
         msg = (
             "Enter a valid site name. It must consist of three uppercase letters (A-Z) followed by an optional single "
-            "digit (0-9)."
+            f"digit (0-9). Received: {site_name}"
         )
         raise ValueError(msg)
     return site_name

gso/workflows/__init__.py

 """Initialisation class that imports all workflows into :term:`GSO`."""
+
 from orchestrator.workflows import LazyWorkflowInstance
 
 LazyWorkflowInstance("gso.workflows.iptrunk.create_iptrunk", "create_iptrunk")

gso/workflows/iptrunk/create_iptrunk.py

@@ -174,7 +174,7 @@ def create_subscription(product: UUIDstr, customer: UUIDstr) -> State:
 
 @step("Get information from IPAM")
 def get_info_from_ipam(subscription: IptrunkProvisioning) -> State:
-    """Allocate :term:`IP` resources in :term:`IPAM`."""
+    """Allocate IP resources in :term:`IPAM`."""
     subscription.iptrunk.iptrunk_ipv4_network = infoblox.allocate_v4_network(
         "TRUNK",
         subscription.iptrunk.iptrunk_description,

gso/workflows/iptrunk/migrate_iptrunk.py

@@ -302,9 +302,7 @@ def confirm_continue_move_fiber() -> FormGenerator:
         class Config:
             title = "Please confirm before continuing"
 
-        info_label: Label = (
-            "New trunk interface has been deployed, wait for the physical connection to be moved."  # type: ignore[assignment]
-        )
+        info_label: Label = "New trunk interface has been deployed, wait for the physical connection to be moved."  # type: ignore[assignment]
 
     yield ProvisioningResultPage
 
@@ -355,9 +353,7 @@ def confirm_continue_restore_isis() -> FormGenerator:
         class Config:
             title = "Please confirm before continuing"
 
-        info_label: Label = (
-            "ISIS config has been deployed, confirm if you want to restore the old metric."  # type: ignore[assignment]
-        )
+        info_label: Label = "ISIS config has been deployed, confirm if you want to restore the old metric."  # type: ignore[assignment]
 
     yield ProvisioningResultPage
 

gso/workflows/iptrunk/modify_trunk_interface.py

@@ -39,8 +39,8 @@ def initialize_ae_members(subscription: Iptrunk, initial_user_input: dict, side_
         iptrunk_speed = initial_user_input["iptrunk_speed"]
 
         class NokiaLAGMember(LAGMember):
-            interface_name: (
-                available_interfaces_choices_including_current_members(  # type: ignore[valid-type]
+            interface_name: (  # type: ignore[valid-type]
+                available_interfaces_choices_including_current_members(
                     router.owner_subscription_id,
                     iptrunk_speed,
                     subscription.iptrunk.iptrunk_sides[side_index].iptrunk_side_ae_members,

pyproject.toml

@@ -26,14 +26,8 @@ disable_error_code = "annotation-unchecked"
 enable_error_code = "ignore-without-code"
 
 [tool.ruff]
-exclude = [
-    ".git",
-    ".*_cache",
-    ".tox",
-    "*.egg-info",
-    "__pycache__",
+extend-exclude = [
     "htmlcov",
-    "venv",
     "gso/migrations",
     "docs",
 ]
@@ -42,7 +36,8 @@ ignore = [
     "D213",
     "N805",
     "PLR0913",
-    "PLR0904"
+    "PLR0904",
+    "PLW1514"
 ]
 line-length = 120
 select = [

test/conftest.py

@@ -186,7 +186,7 @@ def data_config_filename(configuration_data) -> str:
 
     yield f.name
     del os.environ["OSS_PARAMS_FILENAME"]
-    os.remove(f.name)
+    Path(f.name).unlink()
 
 
 @pytest.fixture(scope="session")

test/schedules/test_scheduling.py

@@ -8,7 +8,7 @@ from gso.schedules.scheduling import scheduler
 
 @pytest.fixture(scope="module")
 def validate_subscriptions():
-    from gso.schedules.validate_subscriptions import validate_subscriptions as vs
+    from gso.schedules.validate_subscriptions import validate_subscriptions as vs  # noqa: PLC0415
 
     return vs
 
@@ -32,7 +32,7 @@ def mock_logger():
         yield mock
 
 
-@pytest.fixture
+@pytest.fixture()
 def mock_celery():
     with patch("gso.schedules.scheduling.current_app") as mock_app:
         yield mock_app
@@ -85,7 +85,9 @@ def test_no_subscriptions(mock_get_insync_subscriptions, mock_logger, validate_s
 
 
 def test_subscriptions_without_system_target_workflow(
-    mock_get_insync_subscriptions, mock_logger, validate_subscriptions
+    mock_get_insync_subscriptions,
+    mock_logger,
+    validate_subscriptions,
 ):
     mock_get_insync_subscriptions.return_value = [MagicMock(product=MagicMock(workflows=[]))]
     validate_subscriptions()
@@ -93,7 +95,9 @@ def test_subscriptions_without_system_target_workflow(
 
 
 def test_subscription_status_not_usable(
-    mock_get_insync_subscriptions, mock_get_execution_context, validate_subscriptions
+    mock_get_insync_subscriptions,
+    mock_get_execution_context,
+    validate_subscriptions,
 ):
     subscription_mock = MagicMock()
     subscription_mock.product.workflows = [MagicMock(target=Target.SYSTEM, name="workflow_name")]
@@ -107,7 +111,9 @@ def test_subscription_status_not_usable(
 
 
 def test_valid_subscriptions_for_validation(
-    mock_get_insync_subscriptions, mock_get_execution_context, validate_subscriptions
+    mock_get_insync_subscriptions,
+    mock_get_execution_context,
+    validate_subscriptions,
 ):
     subscription_mock = MagicMock()
     mocked_workflow = MagicMock(target=Target.SYSTEM, name="workflow_name")
@@ -117,5 +123,6 @@ def test_valid_subscriptions_for_validation(
     validate_subscriptions()
     validate_func = mock_get_execution_context()["validate"]
     validate_func.assert_called_once_with(
-        mocked_workflow.name, json=[{"subscription_id": str(subscription_mock.subscription_id)}]
+        mocked_workflow.name,
+        json=[{"subscription_id": str(subscription_mock.subscription_id)}],
     )