Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
GÉANT Service Orchestrator
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
GÉANT Orchestration and Automation Team
GAP
GÉANT Service Orchestrator
Commits
1db26b03
Commit
1db26b03
authored
1 year ago
by
Karel van Klink
Browse files
Options
Downloads
Patches
Plain Diff
remove TODOs that have been resolved
parent
4f208be6
Branches
Branches containing commit
Tags
Tags containing commit
1 merge request
!135
Feature/trunk migration ipam
Pipeline
#85316
passed
1 year ago
Stage: tox
Stage: documentation
Stage: sonarqube
Stage: trigger_jenkins_build
Changes
3
Pipelines
2
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
gso/products/product_blocks/iptrunk.py
+0
-1
0 additions, 1 deletion
gso/products/product_blocks/iptrunk.py
gso/utils/helpers.py
+2
-8
2 additions, 8 deletions
gso/utils/helpers.py
gso/workflows/iptrunk/migrate_iptrunk.py
+0
-2
0 additions, 2 deletions
gso/workflows/iptrunk/migrate_iptrunk.py
with
2 additions
and
11 deletions
gso/products/product_blocks/iptrunk.py
+
0
−
1
View file @
1db26b03
...
@@ -47,7 +47,6 @@ class IptrunkInterfaceBlockInactive(
...
@@ -47,7 +47,6 @@ class IptrunkInterfaceBlockInactive(
):
):
"""
An inactive IP trunk interface.
"""
"""
An inactive IP trunk interface.
"""
# TODO: add validation for interface names, making the type a constrained string
interface_name
:
str
|
None
=
None
interface_name
:
str
|
None
=
None
interface_description
:
str
|
None
=
None
interface_description
:
str
|
None
=
None
...
...
This diff is collapsed.
Click to expand it.
gso/utils/helpers.py
+
2
−
8
View file @
1db26b03
...
@@ -20,19 +20,13 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val
...
@@ -20,19 +20,13 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val
class
LAGMember
(
BaseModel
):
class
LAGMember
(
BaseModel
):
"""
A :term:`LAG` member interface that consists of a name and description.
"""
A :term:`LAG` member interface that consists of a name and description.
"""
TODO: validate interface name
"""
interface_name
:
str
interface_name
:
str
interface_description
:
str
interface_description
:
str
def
__hash__
(
self
)
->
int
:
def
__hash__
(
self
)
->
int
:
"""
Calculate the hash based on the interface name and description, so that uniqueness can be determined.
"""
Calculate the hash based on the interface name and description, so that uniqueness can be determined.
"""
TODO: Check if this is still needed
"""
return
hash
((
self
.
interface_name
,
self
.
interface_description
))
return
hash
((
self
.
interface_name
,
self
.
interface_description
))
...
...
This diff is collapsed.
Click to expand it.
gso/workflows/iptrunk/migrate_iptrunk.py
+
0
−
2
View file @
1db26b03
...
@@ -636,8 +636,6 @@ def migrate_iptrunk() -> StepList:
...
@@ -636,8 +636,6 @@ def migrate_iptrunk() -> StepList:
* Reflect the changes made in :term:`IPAM`
* Reflect the changes made in :term:`IPAM`
* Update the subscription model in the database
* Update the subscription model in the database
* Update the reserved interfaces in Netbox
* Update the reserved interfaces in Netbox
TODO: add interface checks
"""
"""
new_side_is_nokia
=
conditional
(
lambda
state
:
get_router_vendor
(
state
[
"
new_node
"
])
==
RouterVendor
.
NOKIA
)
new_side_is_nokia
=
conditional
(
lambda
state
:
get_router_vendor
(
state
[
"
new_node
"
])
==
RouterVendor
.
NOKIA
)
old_side_is_nokia
=
conditional
(
old_side_is_nokia
=
conditional
(
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment