Skip to content
Snippets Groups Projects
Commit 1db26b03 authored by Karel van Klink's avatar Karel van Klink :smiley_cat:
Browse files

remove TODOs that have been resolved

parent 4f208be6
Branches
Tags
1 merge request!135Feature/trunk migration ipam
Pipeline #85316 passed
...@@ -47,7 +47,6 @@ class IptrunkInterfaceBlockInactive( ...@@ -47,7 +47,6 @@ class IptrunkInterfaceBlockInactive(
): ):
"""An inactive IP trunk interface.""" """An inactive IP trunk interface."""
# TODO: add validation for interface names, making the type a constrained string
interface_name: str | None = None interface_name: str | None = None
interface_description: str | None = None interface_description: str | None = None
......
...@@ -20,19 +20,13 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val ...@@ -20,19 +20,13 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val
class LAGMember(BaseModel): class LAGMember(BaseModel):
"""A :term:`LAG` member interface that consists of a name and description. """A :term:`LAG` member interface that consists of a name and description."""
TODO: validate interface name
"""
interface_name: str interface_name: str
interface_description: str interface_description: str
def __hash__(self) -> int: def __hash__(self) -> int:
"""Calculate the hash based on the interface name and description, so that uniqueness can be determined. """Calculate the hash based on the interface name and description, so that uniqueness can be determined."""
TODO: Check if this is still needed
"""
return hash((self.interface_name, self.interface_description)) return hash((self.interface_name, self.interface_description))
......
...@@ -636,8 +636,6 @@ def migrate_iptrunk() -> StepList: ...@@ -636,8 +636,6 @@ def migrate_iptrunk() -> StepList:
* Reflect the changes made in :term:`IPAM` * Reflect the changes made in :term:`IPAM`
* Update the subscription model in the database * Update the subscription model in the database
* Update the reserved interfaces in Netbox * Update the reserved interfaces in Netbox
TODO: add interface checks
""" """
new_side_is_nokia = conditional(lambda state: get_router_vendor(state["new_node"]) == RouterVendor.NOKIA) new_side_is_nokia = conditional(lambda state: get_router_vendor(state["new_node"]) == RouterVendor.NOKIA)
old_side_is_nokia = conditional( old_side_is_nokia = conditional(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment