From 1db26b035b8182a18d57596f05c101567b2f7ba4 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Tue, 9 Jan 2024 13:27:31 +0100
Subject: [PATCH] remove TODOs that have been resolved
---
gso/products/product_blocks/iptrunk.py | 1 -
gso/utils/helpers.py | 10 ++--------
gso/workflows/iptrunk/migrate_iptrunk.py | 2 --
3 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/gso/products/product_blocks/iptrunk.py b/gso/products/product_blocks/iptrunk.py
index 80419a29..fa10288c 100644
--- a/gso/products/product_blocks/iptrunk.py
+++ b/gso/products/product_blocks/iptrunk.py
@@ -47,7 +47,6 @@ class IptrunkInterfaceBlockInactive(
):
"""An inactive IP trunk interface."""
- # TODO: add validation for interface names, making the type a constrained string
interface_name: str | None = None
interface_description: str | None = None
diff --git a/gso/utils/helpers.py b/gso/utils/helpers.py
index 99a17a37..4bcef047 100644
--- a/gso/utils/helpers.py
+++ b/gso/utils/helpers.py
@@ -20,19 +20,13 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val
class LAGMember(BaseModel):
- """A :term:`LAG` member interface that consists of a name and description.
-
- TODO: validate interface name
- """
+ """A :term:`LAG` member interface that consists of a name and description."""
interface_name: str
interface_description: str
def __hash__(self) -> int:
- """Calculate the hash based on the interface name and description, so that uniqueness can be determined.
-
- TODO: Check if this is still needed
- """
+ """Calculate the hash based on the interface name and description, so that uniqueness can be determined."""
return hash((self.interface_name, self.interface_description))
diff --git a/gso/workflows/iptrunk/migrate_iptrunk.py b/gso/workflows/iptrunk/migrate_iptrunk.py
index 55984e4a..880f62f9 100644
--- a/gso/workflows/iptrunk/migrate_iptrunk.py
+++ b/gso/workflows/iptrunk/migrate_iptrunk.py
@@ -636,8 +636,6 @@ def migrate_iptrunk() -> StepList:
* Reflect the changes made in :term:`IPAM`
* Update the subscription model in the database
* Update the reserved interfaces in Netbox
-
- TODO: add interface checks
"""
new_side_is_nokia = conditional(lambda state: get_router_vendor(state["new_node"]) == RouterVendor.NOKIA)
old_side_is_nokia = conditional(
--
GitLab