diff --git a/gso/products/product_blocks/iptrunk.py b/gso/products/product_blocks/iptrunk.py index 80419a298d9551ef45148f13178e5986e8c9aa0e..fa10288cea07580ffb7f5ab48cd5c1520f8d4a6c 100644 --- a/gso/products/product_blocks/iptrunk.py +++ b/gso/products/product_blocks/iptrunk.py @@ -47,7 +47,6 @@ class IptrunkInterfaceBlockInactive( ): """An inactive IP trunk interface.""" - # TODO: add validation for interface names, making the type a constrained string interface_name: str | None = None interface_description: str | None = None diff --git a/gso/utils/helpers.py b/gso/utils/helpers.py index 99a17a379a6473c70fce3e30f73c63a8576f4194..4bcef047fba589b42e332c080574d5ea9995e3b7 100644 --- a/gso/utils/helpers.py +++ b/gso/utils/helpers.py @@ -20,19 +20,13 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val class LAGMember(BaseModel): - """A :term:`LAG` member interface that consists of a name and description. - - TODO: validate interface name - """ + """A :term:`LAG` member interface that consists of a name and description.""" interface_name: str interface_description: str def __hash__(self) -> int: - """Calculate the hash based on the interface name and description, so that uniqueness can be determined. - - TODO: Check if this is still needed - """ + """Calculate the hash based on the interface name and description, so that uniqueness can be determined.""" return hash((self.interface_name, self.interface_description)) diff --git a/gso/workflows/iptrunk/migrate_iptrunk.py b/gso/workflows/iptrunk/migrate_iptrunk.py index 55984e4ab9fdf2f380ed36aa9fb577921d596f52..880f62f99dff23942a00644c758ad80cb9153aaf 100644 --- a/gso/workflows/iptrunk/migrate_iptrunk.py +++ b/gso/workflows/iptrunk/migrate_iptrunk.py @@ -636,8 +636,6 @@ def migrate_iptrunk() -> StepList: * Reflect the changes made in :term:`IPAM` * Update the subscription model in the database * Update the reserved interfaces in Netbox - - TODO: add interface checks """ new_side_is_nokia = conditional(lambda state: get_router_vendor(state["new_node"]) == RouterVendor.NOKIA) old_side_is_nokia = conditional(