small refactor

src/main/java/net/geant/nmaas/externalservices/kubernetes/RemoteClusterManager.java

@@ -349,7 +349,7 @@ public class RemoteClusterManager implements ClusterMonitoringService {
 
     }
 
-    public boolean clusterExist(Long id) {
+    public boolean clusterExists(Long id) {
         return clusterRepository.existsById(id);
     }
 

src/main/java/net/geant/nmaas/externalservices/kubernetes/entities/KClusterDeployment.java

@@ -12,10 +12,6 @@ import lombok.Builder;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
-import net.geant.nmaas.orchestration.entities.DomainTechDetails;
-import org.apache.commons.lang3.StringUtils;
-
-import java.util.Optional;
 
 @Entity
 @Table(name = "k_cluster_deployment")

src/main/java/net/geant/nmaas/nmservice/deployment/containerorchestrators/kubernetes/KubernetesManager.java

@@ -107,7 +107,7 @@ public class KubernetesManager implements ContainerOrchestrator {
                 appDeployment.getDescriptiveDeploymentId()
         );
         //verify cluster
-        if(remoteClusterManager.clusterExist(appDeployment.getRemoteClusterId())) {
+        if(remoteClusterManager.clusterExists(appDeployment.getRemoteClusterId())) {
            serviceInfo.setRemoteCluster(remoteClusterManager.getCluster(appDeployment.getRemoteClusterId()));
         }
 

src/main/java/net/geant/nmaas/orchestration/tasks/app/AppRequestVerificationTask.java

@@ -43,7 +43,7 @@ public class AppRequestVerificationTask {
             final AppDeployment appDeployment = repository.findByDeploymentId(deploymentId).orElseThrow(() -> new InvalidDeploymentIdException(deploymentId));
             final Application application = appRepository.findById(Long.valueOf(appDeployment.getApplicationId().getValue())).orElseThrow(() ->
                     new InvalidApplicationIdException("Application for deployment " + deploymentId + " does not exist in repository"));
-            if(!remoteClusterManager.clusterExist(appDeployment.getRemoteClusterId())) {
+            if(!remoteClusterManager.clusterExists(appDeployment.getRemoteClusterId())) {
                 throw new InvalidAttributesException("Wrong remote cluster Id");
             }
             serviceDeployment.verifyRequest(

src/test/java/net/geant/nmaas/orchestration/tasks/app/AppRequestVerificationTaskTest.java

@@ -42,7 +42,7 @@ public class AppRequestVerificationTaskTest {
     public void shouldTriggerRequestVerify() throws InterruptedException {
         when(deployments.findByDeploymentId(deploymentId)).thenReturn(Optional.of(AppDeployment.builder().applicationId(Identifier.newInstance(10L)).build()));
         when(applications.findById(any(Long.class))).thenReturn(Optional.of(new Application()));
-        when(remoteClusterManager.clusterExist(any())).thenReturn(true);
+        when(remoteClusterManager.clusterExists(any())).thenReturn(true);
         task.trigger(new AppVerifyRequestActionEvent(this, deploymentId));
         verify(deploy, times(1)).verifyRequest(any(Identifier.class), any(AppDeployment.class), isNull());
     }