Skip to content
Snippets Groups Projects
Commit 3122486f authored by Patryk Kazimierowski's avatar Patryk Kazimierowski
Browse files

changed argument method from AppDeployment to Identifier

parent 4c161415
No related branches found
No related tags found
1 merge request!212Resolve "Add application instance scaling support" -add api
Pipeline #94460 passed
...@@ -2,7 +2,6 @@ package net.geant.nmaas.nmservice.deployment.containerorchestrators.kubernetes; ...@@ -2,7 +2,6 @@ package net.geant.nmaas.nmservice.deployment.containerorchestrators.kubernetes;
import net.geant.nmaas.nmservice.deployment.containerorchestrators.kubernetes.entities.KubernetesTemplate; import net.geant.nmaas.nmservice.deployment.containerorchestrators.kubernetes.entities.KubernetesTemplate;
import net.geant.nmaas.orchestration.Identifier; import net.geant.nmaas.orchestration.Identifier;
import net.geant.nmaas.orchestration.entities.AppDeployment;
public interface KServiceLifecycleManager { public interface KServiceLifecycleManager {
...@@ -16,7 +15,7 @@ public interface KServiceLifecycleManager { ...@@ -16,7 +15,7 @@ public interface KServiceLifecycleManager {
void updateHelmRepo(); void updateHelmRepo();
void scaleDeployment(AppDeployment deployment, int replicas); void scaleDeployment(Identifier deploymentId, int replicas);
} }
...@@ -194,7 +194,7 @@ public class HelmKServiceManager implements KServiceLifecycleManager { ...@@ -194,7 +194,7 @@ public class HelmKServiceManager implements KServiceLifecycleManager {
@Override @Override
@Loggable(LogLevel.TRACE) @Loggable(LogLevel.TRACE)
public void scaleDeployment(AppDeployment deployment, int replicas) { public void scaleDeployment(Identifier deploymentId, int replicas) {
} }
} }
\ No newline at end of file
...@@ -285,7 +285,7 @@ public class DefaultAppLifecycleManager implements AppLifecycleManager { ...@@ -285,7 +285,7 @@ public class DefaultAppLifecycleManager implements AppLifecycleManager {
@Transactional(propagation = Propagation.REQUIRES_NEW) @Transactional(propagation = Propagation.REQUIRES_NEW)
public void scaleDown(Identifier deploymentId) { public void scaleDown(Identifier deploymentId) {
AppDeployment appDeployment = deploymentRepositoryManager.load(deploymentId); AppDeployment appDeployment = deploymentRepositoryManager.load(deploymentId);
kServiceLifecycleManager.scaleDeployment(appDeployment, 0); kServiceLifecycleManager.scaleDeployment(deploymentId, 0);
appDeployment.setState(AppDeploymentState.SCALED_DOWN); appDeployment.setState(AppDeploymentState.SCALED_DOWN);
log.warn("Scaled down deployment NOT IMPLEMENT YET"); log.warn("Scaled down deployment NOT IMPLEMENT YET");
...@@ -295,9 +295,8 @@ public class DefaultAppLifecycleManager implements AppLifecycleManager { ...@@ -295,9 +295,8 @@ public class DefaultAppLifecycleManager implements AppLifecycleManager {
@Loggable(LogLevel.INFO) @Loggable(LogLevel.INFO)
@Transactional(propagation = Propagation.REQUIRES_NEW) @Transactional(propagation = Propagation.REQUIRES_NEW)
public void scaleUp(Identifier deploymentId) { public void scaleUp(Identifier deploymentId) {
AppDeployment appDeployment = deploymentRepositoryManager.load(deploymentId);
int replicas = 1; int replicas = 1;
kServiceLifecycleManager.scaleDeployment(appDeployment, replicas); kServiceLifecycleManager.scaleDeployment(deploymentId, replicas);
log.warn("Scaled up deployment NOT IMPLEMENT YET"); log.warn("Scaled up deployment NOT IMPLEMENT YET");
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment