Skip to content
Snippets Groups Projects
Commit 0049c5b1 authored by kbeyro's avatar kbeyro
Browse files

delete roles, move to domainRole field

parent e82fe2ea
No related branches found
No related tags found
2 merge requests!273Release 1.8.0 update,!247Resolve "Revisit paging mechanism for endpoints providing data for table/list views"
Pipeline #94936 passed
...@@ -30,9 +30,9 @@ public class UserListEntry extends UserBase implements Serializable { ...@@ -30,9 +30,9 @@ public class UserListEntry extends UserBase implements Serializable {
protected OffsetDateTime lastSuccessfulLoginDate; protected OffsetDateTime lastSuccessfulLoginDate;
protected OffsetDateTime firstLoginDate; protected OffsetDateTime firstLoginDate;
protected Set<UserRoleView> roles = new HashSet<>();
protected String globalRole; protected String globalRole;
protected Set<String> domainsName; protected Set<String> domainsName;
protected Role domainRole;
public UserListEntry(User user) { public UserListEntry(User user) {
this.id = user.getId(); this.id = user.getId();
...@@ -56,7 +56,6 @@ public class UserListEntry extends UserBase implements Serializable { ...@@ -56,7 +56,6 @@ public class UserListEntry extends UserBase implements Serializable {
this.globalRole = globalRole.map(Enum::name).orElse(""); this.globalRole = globalRole.map(Enum::name).orElse("");
this.enabled = user.isEnabled(); this.enabled = user.isEnabled();
this.roles = user.getRoles().stream().map(r -> new UserRoleView(r.getRole(), r.getDomain().getId(), r.getDomain().getName())).collect(Collectors.toSet());
} }
} }
...@@ -68,6 +68,7 @@ import java.util.Collections; ...@@ -68,6 +68,7 @@ import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Objects; import java.util.Objects;
import java.util.Optional;
import java.util.Set; import java.util.Set;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import java.util.stream.Stream; import java.util.stream.Stream;
...@@ -177,10 +178,7 @@ public class UsersController { ...@@ -177,10 +178,7 @@ public class UsersController {
@RequestParam(required = false) String searchValue, @RequestParam(required = false) String searchValue,
Principal principal) { Principal principal) {
return userService.findAllListEntry(pageable, searchValue); return userService.findAllListEntry(pageable, searchValue);
} }
@GetMapping("/domains/{domainId}/users/list") @GetMapping("/domains/{domainId}/users/list")
...@@ -206,6 +204,10 @@ public class UsersController { ...@@ -206,6 +204,10 @@ public class UsersController {
pageContent = new ArrayList<>(); pageContent = new ArrayList<>();
} else { } else {
pageContent = allUserInDomain.subList(startItem, endItem); pageContent = allUserInDomain.subList(startItem, endItem);
pageContent.forEach( userListEntry -> {
Optional<Role> domainRole = userService.getUserRoleInDomain(userListEntry.getId(), domainId);
userListEntry.setDomainRole(domainRole.orElse(null));
});
} }
return new PageImpl<>(pageContent, pageable, allUserInDomain.size()); return new PageImpl<>(pageContent, pageable, allUserInDomain.size());
......
...@@ -78,6 +78,8 @@ public interface UserService { ...@@ -78,6 +78,8 @@ public interface UserService {
List<UserListEntry> findAllListEntry(); List<UserListEntry> findAllListEntry();
Optional<Role> getUserRoleInDomain(Long userId, Long domainId);
} }
...@@ -348,7 +348,7 @@ public class UserServiceImpl implements UserService { ...@@ -348,7 +348,7 @@ public class UserServiceImpl implements UserService {
Page<User> all = userRepository.findAll(searchSpec, pageable); Page<User> all = userRepository.findAll(searchSpec, pageable);
return all.map(this::toListView).map(u -> mapUser(u, userLoginDateMap)); return all.map(this::toListView).map(u -> mapUser(u, userLoginDateMap));
} else { } else {
return userRepository.findAllListEntry(pageable); return userRepository.findAllListEntry(pageable).map(u -> mapUser(u, userLoginDateMap));
} }
} }
...@@ -362,6 +362,11 @@ public class UserServiceImpl implements UserService { ...@@ -362,6 +362,11 @@ public class UserServiceImpl implements UserService {
return userRepository.findAllListEntry(); return userRepository.findAllListEntry();
} }
@Override
public Optional<Role> getUserRoleInDomain(Long userId, Long domainId) {
return this.userRoleRepository.findRolesByDomainAndUser(domainId, userId).stream().findFirst();
}
private void sendMail(User user, MailType mailType) { private void sendMail(User user, MailType mailType) {
ImmutableMap<String, Object> map; ImmutableMap<String, Object> map;
if (mailType == MailType.NEW_BULK_LOGIN) { if (mailType == MailType.NEW_BULK_LOGIN) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment