Force boolean comparison on insync in unit tests

To avoid accidentally asserting insync is equal to "some string" which is also truthy

test/workflows/edge_port/test_import_edge_port.py

@@ -15,4 +15,4 @@ def test_import_edge_port_success(edge_port_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.EDGE_PORT
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/iptrunk/test_import_iptrunk.py

@@ -15,4 +15,4 @@ def test_import_iptrunk_success(iptrunk_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.IP_TRUNK
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/nren_l3_core_service/test_import_nren_l3_core_service.py

@@ -20,4 +20,4 @@ def test_import_nren_l3_core_service_success(nren_l3_core_service_subscription_f
     #  Remove the "IMPORTED_" prefix with ``[9:]``
     assert subscription.nren_l3_core_service_type == NRENL3CoreServiceType(l3_core_service_type.value[9:])
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/nren_l3_core_service/test_migrate_nren_l3_core_service.py

@@ -43,7 +43,7 @@ def test_migrate_nren_l3_core_service_success(
     assert_complete(result)
     state = extract_state(result)
     subscription = NRENL3CoreService.from_subscription(state["subscription_id"])
-    assert subscription.insync
+    assert subscription.insync is True
     assert len(subscription.nren_l3_core_service.nren_ap_list) == 2
     assert str(subscription.nren_l3_core_service.nren_ap_list[0].sbp.edge_port.owner_subscription_id) == new_edge_port_1
     assert str(subscription.nren_l3_core_service.nren_ap_list[1].sbp.edge_port.owner_subscription_id) == new_edge_port_2

test/workflows/office_router/test_import_office_router.py

@@ -15,4 +15,4 @@ def test_import_office_router_success(office_router_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.OFFICE_ROUTER
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/opengear/test_import_opengear.py

@@ -15,4 +15,4 @@ def test_import_office_router_success(opengear_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.OPENGEAR
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/router/test_import_router.py

@@ -15,4 +15,4 @@ def test_import_site_success(router_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.ROUTER
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/site/test_import_site.py

@@ -15,4 +15,4 @@ def test_import_site_success(site_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.SITE
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True

test/workflows/super_pop_switch/test_import_super_pop_switch.py

@@ -15,4 +15,4 @@ def test_import_super_pop_switch_success(super_pop_switch_subscription_factory):
     assert_complete(result)
     assert subscription.product.name == ProductName.SUPER_POP_SWITCH
     assert subscription.status == SubscriptionLifecycle.ACTIVE
-    assert subscription.insync
+    assert subscription.insync is True