From c6812cb47d98a471a685c4e0431f548ae05fc390 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Wed, 23 Oct 2024 14:23:09 +0200
Subject: [PATCH] Force boolean comparison on insync in unit tests
To avoid accidentally asserting insync is equal to "some string" which is also truthy
---
test/workflows/edge_port/test_import_edge_port.py | 2 +-
test/workflows/iptrunk/test_import_iptrunk.py | 2 +-
.../nren_l3_core_service/test_import_nren_l3_core_service.py | 2 +-
.../nren_l3_core_service/test_migrate_nren_l3_core_service.py | 2 +-
test/workflows/office_router/test_import_office_router.py | 2 +-
test/workflows/opengear/test_import_opengear.py | 2 +-
test/workflows/router/test_import_router.py | 2 +-
test/workflows/site/test_import_site.py | 2 +-
test/workflows/super_pop_switch/test_import_super_pop_switch.py | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/test/workflows/edge_port/test_import_edge_port.py b/test/workflows/edge_port/test_import_edge_port.py
index 6d79e89d..7fb1fcbd 100644
--- a/test/workflows/edge_port/test_import_edge_port.py
+++ b/test/workflows/edge_port/test_import_edge_port.py
@@ -15,4 +15,4 @@ def test_import_edge_port_success(edge_port_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.EDGE_PORT
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/iptrunk/test_import_iptrunk.py b/test/workflows/iptrunk/test_import_iptrunk.py
index 99cdbfd9..52a52c32 100644
--- a/test/workflows/iptrunk/test_import_iptrunk.py
+++ b/test/workflows/iptrunk/test_import_iptrunk.py
@@ -15,4 +15,4 @@ def test_import_iptrunk_success(iptrunk_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.IP_TRUNK
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/nren_l3_core_service/test_import_nren_l3_core_service.py b/test/workflows/nren_l3_core_service/test_import_nren_l3_core_service.py
index b155bb72..13095de6 100644
--- a/test/workflows/nren_l3_core_service/test_import_nren_l3_core_service.py
+++ b/test/workflows/nren_l3_core_service/test_import_nren_l3_core_service.py
@@ -20,4 +20,4 @@ def test_import_nren_l3_core_service_success(nren_l3_core_service_subscription_f
# Remove the "IMPORTED_" prefix with ``[9:]``
assert subscription.nren_l3_core_service_type == NRENL3CoreServiceType(l3_core_service_type.value[9:])
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/nren_l3_core_service/test_migrate_nren_l3_core_service.py b/test/workflows/nren_l3_core_service/test_migrate_nren_l3_core_service.py
index 95d6d68b..a4ad8a9f 100644
--- a/test/workflows/nren_l3_core_service/test_migrate_nren_l3_core_service.py
+++ b/test/workflows/nren_l3_core_service/test_migrate_nren_l3_core_service.py
@@ -43,7 +43,7 @@ def test_migrate_nren_l3_core_service_success(
assert_complete(result)
state = extract_state(result)
subscription = NRENL3CoreService.from_subscription(state["subscription_id"])
- assert subscription.insync
+ assert subscription.insync is True
assert len(subscription.nren_l3_core_service.nren_ap_list) == 2
assert str(subscription.nren_l3_core_service.nren_ap_list[0].sbp.edge_port.owner_subscription_id) == new_edge_port_1
assert str(subscription.nren_l3_core_service.nren_ap_list[1].sbp.edge_port.owner_subscription_id) == new_edge_port_2
diff --git a/test/workflows/office_router/test_import_office_router.py b/test/workflows/office_router/test_import_office_router.py
index c9894e98..e86e3ed1 100644
--- a/test/workflows/office_router/test_import_office_router.py
+++ b/test/workflows/office_router/test_import_office_router.py
@@ -15,4 +15,4 @@ def test_import_office_router_success(office_router_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.OFFICE_ROUTER
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/opengear/test_import_opengear.py b/test/workflows/opengear/test_import_opengear.py
index 37c7d171..6ca1da25 100644
--- a/test/workflows/opengear/test_import_opengear.py
+++ b/test/workflows/opengear/test_import_opengear.py
@@ -15,4 +15,4 @@ def test_import_office_router_success(opengear_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.OPENGEAR
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/router/test_import_router.py b/test/workflows/router/test_import_router.py
index 3c06b338..2bab9ac2 100644
--- a/test/workflows/router/test_import_router.py
+++ b/test/workflows/router/test_import_router.py
@@ -15,4 +15,4 @@ def test_import_site_success(router_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.ROUTER
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/site/test_import_site.py b/test/workflows/site/test_import_site.py
index ac476c10..f706a473 100644
--- a/test/workflows/site/test_import_site.py
+++ b/test/workflows/site/test_import_site.py
@@ -15,4 +15,4 @@ def test_import_site_success(site_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.SITE
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
diff --git a/test/workflows/super_pop_switch/test_import_super_pop_switch.py b/test/workflows/super_pop_switch/test_import_super_pop_switch.py
index 4d20774c..2961b539 100644
--- a/test/workflows/super_pop_switch/test_import_super_pop_switch.py
+++ b/test/workflows/super_pop_switch/test_import_super_pop_switch.py
@@ -15,4 +15,4 @@ def test_import_super_pop_switch_success(super_pop_switch_subscription_factory):
assert_complete(result)
assert subscription.product.name == ProductName.SUPER_POP_SWITCH
assert subscription.status == SubscriptionLifecycle.ACTIVE
- assert subscription.insync
+ assert subscription.insync is True
--
GitLab