Skip to content
Snippets Groups Projects
Verified Commit ae68be3b authored by Karel van Klink's avatar Karel van Klink :smiley_cat:
Browse files

update method name to prevent confusion

parent ae0ba33f
No related branches found
No related tags found
1 merge request!128Feature/use conditionals
......@@ -90,7 +90,7 @@ def deprovision_ip_trunk_real(subscription: Iptrunk, process_id: UUIDstr, callba
return {"subscription": subscription}
def _remove_interface_from_netbox(side_block: IptrunkSideBlock) -> None:
def _free_up_interfaces_from_netbox(side_block: IptrunkSideBlock) -> None:
nbclient = NetboxClient()
for member in side_block.iptrunk_side_ae_members:
......@@ -101,17 +101,17 @@ def _remove_interface_from_netbox(side_block: IptrunkSideBlock) -> None:
@step("Netbox: Remove interfaces on side A")
def netbox_remove_side_a_interfaces(subscription: Iptrunk) -> State:
def netbox_clean_up_side_a(subscription: Iptrunk) -> State:
"""Mark used interfaces on side A as free in Netbox."""
_remove_interface_from_netbox(subscription.iptrunk.iptrunk_sides[0])
_free_up_interfaces_from_netbox(subscription.iptrunk.iptrunk_sides[0])
return {"subscription": subscription}
@step("Netbox: Remove interfaces on side B")
def netbox_remove_side_b_interfaces(subscription: Iptrunk) -> State:
def netbox_clean_up_side_b(subscription: Iptrunk) -> State:
"""Mark used interfaces on side B as free in Netbox."""
_remove_interface_from_netbox(subscription.iptrunk.iptrunk_sides[1])
_free_up_interfaces_from_netbox(subscription.iptrunk.iptrunk_sides[1])
return {"subscription": subscription}
......@@ -177,8 +177,8 @@ def terminate_iptrunk() -> StepList:
>> store_process_subscription(Target.TERMINATE)
>> unsync
>> run_config_steps(config_steps)
>> side_a_is_nokia(netbox_remove_side_a_interfaces)
>> side_b_is_nokia(netbox_remove_side_b_interfaces)
>> side_a_is_nokia(netbox_clean_up_side_a)
>> side_b_is_nokia(netbox_clean_up_side_b)
>> run_ipam_steps(ipam_steps)
>> set_status(SubscriptionLifecycle.TERMINATED)
>> resync
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment