Feature/use conditionals
Use conditionals to skip workflow steps, instead of using a big if-statement
Merge request reports
Activity
requested review from @mohammad.torkashvand
assigned to @karel.vanklink
requested review from @neda.moeini and removed review request for @mohammad.torkashvand
@karel.vanklink I think we must also add the same condition for creating/terminating/Modifying IP Trunk. Since the condition is different in these steps(we need to check the vendor for each side) it's more complicated than router workflows. What do you think about returning a variable to steps? like this: vendors: {sideA: Nokia, sideB: Juniper} and skip steps that don't have any Nokia side?
@neda.moeini I've added conditionals to the IP trunk workflows as well now
This included splitting some workflow steps up into two (one a-side and one b-side)- Resolved by Karel van Klink
@karel.vanklink Thanks for the update. It looks great. I think we need the very same thing for modification workflow as well.
This looks great. We need to fix the pipeline and hopefully merge it with develop @karel.vanklink Thanks
added 1 commit
- f83780eb - use conditionals and reformat some code in modify iptrunk interface workflow
added 26 commits
-
f83780eb...6191d0fe - 17 commits from branch
develop
- a34051ad - use a conditional to skip a step in migrate_iptrunk
- 3d1d07b9 - use conditional to skip step in create_router workflow
- 51ffc223 - use a conditional to skip a step in terminate_router
- ad025703 - add conditionals to the IP trunk creation workflow
- 02d70cb8 - ruff: ignore COM812
- 7d8f2630 - use conditionals in IP trunk migration workflow
- ae0ba33f - use conditionals in IP trunk termination workflow
- ae68be3b - update method name to prevent confusion
- 83e3b12a - use conditionals and reformat some code in modify iptrunk interface workflow
Toggle commit list-
f83780eb...6191d0fe - 17 commits from branch
enabled an automatic merge when the pipeline for 83e3b12a succeeds