NAT-328: changed generator for site name in more readable code

test/conftest.py

@@ -60,17 +60,13 @@ class FakerProvider(BaseProvider):
         return self.generator.numerify("SID-#####")
 
     def site_name(self) -> str:
-        # define pointer to random letter method
-        def get_upper():
-            return self.generator.random_letter().upper()
-
-        random_int = self.generator.random_int(min=0, max=1)
-        if random_int == 0:
-            # Returns ABC0...ABC9
-            return get_upper() + get_upper() + get_upper() + str(self.generator.random_int(min=0, max=9))
-        elif random_int == 1:
-            # Returns ABC
-            return get_upper() + get_upper() + get_upper()
+        site_name = ''.join(self.generator.random_letter().upper() for _ in range(3))
+
+        if self.generator.boolean():
+            digit = self.generator.random_int(min=1, max=9)
+            site_name += str(digit)
+
+        return site_name
 
     def network_interface(self) -> str:
         return self.generator.numerify("ge-@#/@#/@#")