From 5158293f966cd1a50d3e9e7a7c8be2ba8f6aeb88 Mon Sep 17 00:00:00 2001
From: Hakan Calim <hakan.calim@fau.de>
Date: Thu, 26 Oct 2023 16:48:07 +0200
Subject: [PATCH] NAT-328: changed generator for site name in more readable
 code

---
 test/conftest.py | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/test/conftest.py b/test/conftest.py
index 8d08f7b5..09dacb41 100644
--- a/test/conftest.py
+++ b/test/conftest.py
@@ -60,17 +60,13 @@ class FakerProvider(BaseProvider):
         return self.generator.numerify("SID-#####")
 
     def site_name(self) -> str:
-        # define pointer to random letter method
-        def get_upper():
-            return self.generator.random_letter().upper()
-
-        random_int = self.generator.random_int(min=0, max=1)
-        if random_int == 0:
-            # Returns ABC0...ABC9
-            return get_upper() + get_upper() + get_upper() + str(self.generator.random_int(min=0, max=9))
-        elif random_int == 1:
-            # Returns ABC
-            return get_upper() + get_upper() + get_upper()
+        site_name = ''.join(self.generator.random_letter().upper() for _ in range(3))
+
+        if self.generator.boolean():
+            digit = self.generator.random_int(min=1, max=9)
+            site_name += str(digit)
+
+        return site_name
 
     def network_interface(self) -> str:
         return self.generator.numerify("ge-@#/@#/@#")
-- 
GitLab