Skip to content
Snippets Groups Projects

Feature/dboard3 920 populate snmp interface info

Merged Feature/dboard3 920 populate snmp interface info
feature/DBOARD3-920_populate_snmp_interface_info into develop
3 unresolved threads
Merged Robert Latta requested to merge feature/DBOARD3-920_populate_snmp_interface_info into develop
3 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
inventory_provider/tasks/worker.py
103 103 InventoryTask.config.get('unmanaged-interfaces', []))
104 104
105 105
106 def _nokia_community_strings(config_):
107 return {
108 'inventory-provider': config_['nokia-community-inventory-provider'],
109 'dashboard': config_['nokia-community-dashboard'],
110 'brian': config_['nokia-community-brian']
111 }
  • Comment on lines +106 to +111
    Erik Reid
    Erik Reid @erik.reid ·
    Owner

    what's your idea of handling different environments? if puppet provisions different community strings for different environments (test/uat/prod), then isn't this a separation of the business logic? but if not, the app needs to know which environment it's running in ...

  • Robert Latta
    Robert Latta @Robert.Latta ·
    Author Maintainer

    Puppet does indeed provision different community strings for each environment. In the relevant worker finalisation code or API endpoint the relevant community is selected. What would you suggestion be for this?

  • Erik Reid
    Erik Reid @erik.reid ·
    Owner

    yes, both are non symmetric, let me get my head around it

    ... but someday we will have to add authentication to inventory provider, and then this will be prettier (can return the community string based on auth creds)

  • Please register or sign in to reply
  • Erik Reid
    Erik Reid @erik.reid started a thread on the diff
    • inventory_provider/nokia.py
    34 36 'g': 'Gbps',
    35 37 'G': 'Gbps',
    36 38 }
    39 STATE_FILTER = '''<filter>
  • Erik Reid
    Erik Reid @erik.reid started a thread on the diff
    • inventory_provider/config.py
    234 222 'items': {'$ref': '#/definitions/interface-address'}
    235 223 },
    236 224 'gws-direct': {'$ref': '#/definitions/gws-direct'},
    237 'nren-asn-map': {'$ref': '#/definitions/nren-asn-map'}
    225 'nren-asn-map': {'$ref': '#/definitions/nren-asn-map'},
  • Robert Latta mentioned in commit 40c7659b

    mentioned in commit 40c7659b

  • Robert Latta merged

    merged

    • Please register or sign in to reply