Skip to content
Snippets Groups Projects
Erik Reid's avatar
deleted branch patch/dependency at geant-swd / dashboardv3 / inventory-provider
Erik Reid's avatar
accepted merge request !51 "Add missing dependency in setup.py" at geant-swd / dashboardv3 / inventory-provider
Erik Reid's avatar
Adeel Ahmad's avatar
opened merge request !51 "Add missing dependency in setup.py" at geant-swd / dashboardv3 / inventory-provider
Adeel Ahmad's avatar
pushed new branch patch/dependency at geant-swd / dashboardv3 / inventory-provider
Adeel Ahmad's avatar
deleted branch DBOARD3-1142/token-auth at geant-swd / dashboardv3 / inventory-provider
Adeel Ahmad's avatar
accepted merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider
Adeel Ahmad's avatar
Erik Reid's avatar
pushed to branch DBOARD3-1142/token-auth at geant-swd / dashboardv3 / inventory-provider
Adeel Ahmad's avatar
pushed to branch DBOARD3-1142/token-auth at geant-swd / dashboardv3 / inventory-provider
  • 10f5ba5c · Add type hinting and Enum definition for service names
Adeel Ahmad's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

Added type hinting.

Adeel Ahmad's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

Added type hinting.

Adeel Ahmad's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

Updated.

Adeel Ahmad's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

Updated to use Enum.

Adeel Ahmad's avatar
pushed to branch DBOARD3-1142/token-auth at geant-swd / dashboardv3 / inventory-provider
  • 4259a38f · Add type hinting and Enum definition for service names
Erik Reid's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

type hint this def

Erik Reid's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

if client names are an Enum, type hinting

Erik Reid's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

these DEFAULT_REQUEST_HEADERS* are only used once each. It's cleaner to define them only once where they're used ... this way increases the possib...

Erik Reid's avatar
commented on merge request !50 "Dboard3 1142/token auth" at geant-swd / dashboardv3 / inventory-provider

I think these would be more elegant as Enums. And then you can add type hinting to authorize().

Robert Latta's avatar