Skip to content
Snippets Groups Projects

Feature/reporting 311 add msr asn peers

Merged Sam Roberts requested to merge feature/REPORTING-311-add-msr-asn-peers into develop
All threads resolved!

Ready for merge (pending additional functionality wrt caching and NRENs)

Edited by Sam Roberts

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Developer

    @erik.reid How feasible do you think caching could be with this endpoint? I'm a little concerned given the variation in requests it could lead to a lot of cached requests that aren't made very often, but I can definitely see the value in caching the most common use case according to Bjarke (no filters, all ASNs in the ASN-NREN map)

  • Sam Roberts resolved all threads

    resolved all threads

  • Sam Roberts changed the description

    changed the description

  • We should cache everything. Just come up with some encoding for generating keys that include the parameters. We have plenty of space in memory for these all cached results, and it would make the code complicated and less clear to cache sometimes and not cache other times based on some guessed optimizations.

  • Sam Roberts added 2 commits

    added 2 commits

    • 7936f4a3 - rewritten to provide NREN, and to use caching
    • d2994a77 - adjusted tests to work with providing NRENs

    Compare with previous version

  • Sam Roberts added 1 commit

    added 1 commit

    • 94774acb - fixed a bug involving ASN not being presented as integer correctly

    Compare with previous version

  • Sam Roberts added 1 commit

    added 1 commit

    • a5822127 - remove unused import to make tox happy

    Compare with previous version

  • Author Developer

    Caching and NREN return added, all tests adjusted, coverage for endpoint is complete and Bjarke thinks this all looks fine, so I'm going to go ahead and merge this.

  • Sam Roberts mentioned in commit 3f8eb4ea

    mentioned in commit 3f8eb4ea

  • merged

  • Please register or sign in to reply
    Loading