Feature/reporting 311 add msr asn peers
Ready for merge (pending additional functionality wrt caching and NRENs)
Merge request reports
Activity
requested review from @bjarke.madsen
assigned to @sam.roberts
added 1 commit
- 1a5861b1 - unit tests added, need to fix bug causing error in tests before these are reached
added 1 commit
- 07db6a02 - all code paths in endpoint covered by unit tests
- Resolved by Sam Roberts
@erik.reid How feasible do you think caching could be with this endpoint? I'm a little concerned given the variation in requests it could lead to a lot of cached requests that aren't made very often, but I can definitely see the value in caching the most common use case according to Bjarke (no filters, all ASNs in the ASN-NREN map)
We should cache everything. Just come up with some encoding for generating keys that include the parameters. We have plenty of space in memory for these all cached results, and it would make the code complicated and less clear to cache sometimes and not cache other times based on some guessed optimizations.
added 1 commit
- 94774acb - fixed a bug involving ASN not being presented as integer correctly
mentioned in commit 3f8eb4ea