only build snmp indices once per endpoint request

inventory_provider/routes/poller.py

@@ -67,6 +67,7 @@ import itertools
 import json
 import logging
 import re
+from functools import partial
 
 from flask import Blueprint, Response, current_app, request, jsonify
 
@@ -1214,9 +1215,7 @@ def _get_services_internal(service_type=None):
                 num_threads=20):
             yield doc['value']
 
-    def _add_snmp(s):
-        all_snmp_info = common.load_snmp_indexes(
-            current_app.config['INVENTORY_PROVIDER_CONFIG'], )
+    def _add_snmp(s, all_snmp_info):
         snmp_interfaces = all_snmp_info.get(s['hostname'], {})
         interface_info = snmp_interfaces.get(s['interface'], None)
         if interface_info:
@@ -1272,7 +1271,8 @@ def _get_services_internal(service_type=None):
         result = filter(_wanted_in_output, result)
         result = map(_format_services, result)
         if include_snmp:
-            result = map(_add_snmp, result)
+            all_snmp_info = common.load_snmp_indexes(current_app.config['INVENTORY_PROVIDER_CONFIG'], )
+            result = map(partial(_add_snmp, all_snmp_info=all_snmp_info), result)
         result = list(result)
 
         if not result:

[Bjarke Madsen]

@sam.roberts maybe remove the extra comma at the end of this function call

[Bjarke Madsen]

And also format to be <= 79 width

[Sam Roberts]

noting here for future reference: max width is now 120, I've made a change to the tox config to reflect this