return list of device structures

inventory_provider/juniper.py

 import logging
+import re
 
 from jnpr.junos import Device
 from lxml import etree
@@ -294,4 +295,18 @@ def load_routers_from_junosspace(config):
             juniper_logger.error("%d.%d: %s" % (e.line, e.column, e.message))
         assert False
 
-    return True
+    for d in devices.xpath('//devices/device'):
+        name = d.xpath('./name/text()')[0]
+        # TODO: ask ops if this name->hostname operation is valid
+        m = re.match(r'^(.*)\.re\d+$', name)
+        if m:
+            hostname = m.group(1) + '.geant.net'
+        else:
+            hostname = None
+        yield {
+            "OSVersion": d.xpath('./OSVersion/text()')[0],
+            "platform": d.xpath('./platform/text()')[0],
+            "address": d.xpath('./ipAddr/text()')[0],
+            "name": name,
+            "hostname": hostname
+        }

test/test_junosspace_io.py

@@ -22,5 +22,5 @@ def test_junosspace_devices_parsing(data_config):
             url = data_config['junosspace']['api'] + '/device-management/devices',
             body=f.read())
 
-    doc = juniper.load_routers_from_junosspace(data_config['junosspace'])
-    assert doc
+    routers = juniper.load_routers_from_junosspace(data_config['junosspace'])
+    print(list(routers))