Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
I
inventory-provider
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
geant-swd
dashboardv3
inventory-provider
Commits
d3f3a9c9
Commit
d3f3a9c9
authored
1 year ago
by
Sam Roberts
Browse files
Options
Downloads
Patches
Plain Diff
add unit tests for parsing speeds from interface-info documents
parent
841a124a
Branches
Branches containing commit
Tags
Tags containing commit
1 merge request
!22
Feature/pol1 744 fix speed issues
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
test/per_router/conftest.py
+42
-0
42 additions, 0 deletions
test/per_router/conftest.py
test/per_router/test_juniper_data.py
+10
-0
10 additions, 0 deletions
test/per_router/test_juniper_data.py
with
52 additions
and
0 deletions
test/per_router/conftest.py
+
42
−
0
View file @
d3f3a9c9
...
...
@@ -2,9 +2,13 @@ import glob
import
json
import
os
import
re
from
unittest.mock
import
patch
from
lxml
import
etree
import
pytest
from
ncclient.manager
import
make_device_handler
,
Manager
from
ncclient.transport
import
SSHSession
from
ncclient.xml_
import
NCElement
import
inventory_provider
from
inventory_provider
import
juniper
...
...
@@ -64,3 +68,41 @@ def netconf_doc(mocker, router, data_config):
'
inventory_provider.juniper.Device
'
,
MockedJunosDevice
)
return
juniper
.
load_config
(
router
,
data_config
[
'
ssh
'
])
# different library requires different mocking
@pytest.fixture
def
interface_info_response
(
router
):
filename
=
os
.
path
.
join
(
TEST_DATA_DIRNAME
,
'
interface_info
'
,
f
'
{
router
}
.xml
'
)
try
:
with
open
(
filename
,
'
r
'
)
as
file
:
data
=
file
.
read
()
return
data
except
FileNotFoundError
:
pytest
.
skip
(
f
'
no corresponding interface_info doc for
{
router
}
, skipping
'
)
@pytest.fixture
def
mocked_router
(
interface_info_response
):
def
_mocked_manager_connect
(
*
args
,
**
kwargs
):
assert
kwargs
device_params
=
kwargs
[
"
device_params
"
]
device_handler
=
make_device_handler
(
device_params
)
session
=
SSHSession
(
device_handler
)
return
Manager
(
session
,
device_handler
)
def
_mocked_rpc_reply
(
*
args
,
**
kwargs
):
device_handler
=
make_device_handler
({
'
name
'
:
'
junos
'
})
rpc_reply
=
NCElement
(
interface_info_response
,
device_handler
.
transform_reply
()
)
return
rpc_reply
with
patch
(
'
ncclient.manager.connect
'
)
as
manager
:
manager
.
side_effect
=
_mocked_manager_connect
with
patch
(
'
ncclient.operations.third_party.juniper.rpc.ExecuteRpc._request
'
)
as
rpc
:
rpc
.
side_effect
=
_mocked_rpc_reply
with
patch
(
'
ncclient.operations.session.CloseSession.request
'
):
yield
This diff is collapsed.
Click to expand it.
test/per_router/test_juniper_data.py
+
10
−
0
View file @
d3f3a9c9
...
...
@@ -2,6 +2,8 @@ import copy
import
ipaddress
import
jsonschema
import
pytest
from
lxml
import
etree
from
inventory_provider
import
juniper
from
inventory_provider.routes
import
msr
...
...
@@ -143,3 +145,11 @@ def test_interface_addresses_list(netconf_doc):
addresses
=
list
(
juniper
.
interface_addresses
(
netconf_doc
))
jsonschema
.
validate
(
addresses
,
schema
)
def
test_interface_speeds
(
mocked_router
,
router
,
data_config
):
interface_info
=
juniper
.
get_interface_info_for_router
(
router
,
data_config
[
'
ssh
'
])
speeds
=
juniper
.
get_interface_speeds
(
etree
.
fromstring
(
interface_info
))
assert
len
(
speeds
)
>
0
# should have any speeds at all
for
speed
in
speeds
:
assert
len
(
speed
)
>
0
# no empty strings, every found speed should have a value
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment