added & fixed snmp task tests

test/conftest.py

@@ -226,12 +226,22 @@ def mocked_worker_module(
         'inventory_provider.tasks.worker.InventoryTask.send_event',
         _mocked_send_event)
 
-    def _mocked_snmp_interfaces(hostname, community):
+    def _mocked_snmp_interfaces(hostname, community, logical_systems):
         return json.loads(cached_test_data['snmp-interfaces:' + hostname])
     mocker.patch(
         'inventory_provider.snmp.get_router_snmp_indexes',
         _mocked_snmp_interfaces)
 
+    def _mocked_snmp_peerings(hostname, community, logical_systems):
+        def _wanted(s):
+            return re.match('^snmp-peerings:\d.*', s)
+
+        keys = filter(_wanted, cached_test_data.keys())
+        return [json.loads(cached_test_data[k]) for k in keys]
+    mocker.patch(
+        'inventory_provider.snmp.get_peer_state_info',
+        _mocked_snmp_peerings)
+
     def _mocked_load_juniper_netconf_config(hostname, _):
         return etree.XML(cached_test_data['netconf:' + hostname])
     mocker.patch(

test/per_router/test_celery_worker.py

@@ -24,20 +24,39 @@ def test_netconf_refresh_config(mocked_worker_module, router):
 
 def test_snmp_refresh_interfaces(mocked_worker_module, router):
 
+    def _wanted(s):
+        return s.startswith(f'snmp-interfaces-single:{router}')
+
     def _ifc_keys():
-        return [
-            k for k in backend_db().keys() if k.startswith(single_prefix)]
+        return filter(_wanted, backend_db().keys())
 
     del backend_db()[f'snmp-interfaces:{router}']
-    single_prefix = f'snmp-interfaces-single:{router}'
     for k in list(_ifc_keys()):
         del backend_db()[k]
 
-    worker.snmp_refresh_interfaces(router, 'fake-community')
+    worker.snmp_refresh_interfaces(router, 'fake-community', [])
     assert backend_db()['snmp-interfaces:' + router]
     assert list(_ifc_keys())
 
 
+def test_snmp_refresh_peerings(mocked_worker_module, router):
+
+    def _wanted(s):
+        return s.startswith(f'snmp-peerings:')
+
+    def _ifc_keys():
+        return filter(_wanted, backend_db().keys())
+
+
+    del backend_db()[f'snmp-interfaces:{router}']
+    single_prefix = f'snmp-interfaces-single:{router}'
+    for k in list(_ifc_keys()):
+        del backend_db()[k]
+
+    worker.snmp_refresh_peerings(router, 'fake-community', [])
+    assert list(_ifc_keys())
+
+
 def test_reload_router_config(mocked_worker_module, router, mocker):
     saved_data = {}
     for key in ('netconf:' + router, 'snmp-interfaces:' + router):

test/per_router/test_data_routes.py

@@ -56,7 +56,8 @@ def test_snmp_ids(router, client):
             "type": "object",
             "properties": {
                 "index": {"type": "integer"},
-                "name": {"type": "string"}
+                "name": {"type": "string"},
+                "community": {"type": "string"}
             },
             "required": ["index", "name"],
             "additionalProperties": False