Finished feature handle-propagated-errors-in-task-result.

inventory_provider/snmp.py

@@ -57,9 +57,19 @@ def walk(agent_hostname, community, base_oid):  # pragma: no cover
             lexicographicMode=False,
             lookupNames=True,
             lookupValues=True):
-        assert not engineErrorIndication
-        assert not pduErrorIndication
-        assert errorIndex == 0
+
+        # cf. http://snmplabs.com/
+        #       pysnmp/examples/hlapi/asyncore/sync/contents.html
+        assert not engineErrorIndication, (
+            'snmp response engine error indication: %r'
+            % str(engineErrorIndication))
+        assert not pduErrorIndication, 'snmp response pdu error %r at %r' % (
+            pduErrorIndication,
+            errorIndex and varBinds[int(errorIndex) - 1][0] or '?')
+        assert errorIndex == 0, (
+            'sanity failure: errorIndex != 0, '
+            'but no error indication')
+
         # varBinds = [
         #     rfc1902.ObjectType(rfc1902.ObjectIdentity(x[0]),x[1])
         #         .resolveWithMib(mibViewController)

inventory_provider/tasks/worker.py

@@ -416,5 +416,13 @@ def check_task_status(task_id):
         'success': r.status == states.SUCCESS,
     }
     if r.result:
-        result['result'] = r.result
+        # TODO: only discovered this case by testing, is this the only one?
+        #       ... otherwise need to pre-test json serialization
+        if isinstance(r.result, Exception):
+            result['result'] = {
+                'error type': type(r.result).__name__,
+                'message': str(r.result)
+            }
+        else:
+            result['result'] = r.result
     return result