Make dashboard_info required, _get_interface_type private

inventory_provider/routes/poller.py

@@ -167,7 +167,7 @@ INTERFACE_LIST_SCHEMA = {
             'required': [
                 'router', 'name', 'description',
                 'snmp-index', 'bundle', 'bundle-parents',
-                'circuits', 'dashboards'],
+                'circuits', 'dashboards', 'dashboard_info'],
             'additionalProperties': False
         },
     },
@@ -421,26 +421,31 @@ def _get_dashboards(interface):
         yield BRIAN_DASHBOARDS.NREN
 
 
-def _get_interface_type(interface):
-    description = interface.get('description', '').strip()
-    if re.match(r'^PHY', description):
-        return INTERFACE_TYPES.PHYSICAL
-    if re.match(r'^SRV_', description):
-        return INTERFACE_TYPES.LOGICAL
-    if re.match(r'^LAG', description):
-        return INTERFACE_TYPES.AGGREGATE
-
-    return INTERFACE_TYPES.UNKNOWN
+def _get_dashboard_data(ifc):
 
+    def _get_interface_type(description):
+        if re.match(r'^PHY', description):
+            return INTERFACE_TYPES.PHYSICAL
+        if re.match(r'^SRV_', description):
+            return INTERFACE_TYPES.LOGICAL
+        if re.match(r'^LAG', description):
+            return INTERFACE_TYPES.AGGREGATE
 
-def _get_dashboard_data(ifc):
-    interface_type = _get_interface_type(ifc)
+        return INTERFACE_TYPES.UNKNOWN
 
     description = ifc.get('description', '').strip()
     dashboards = ifc.get('dashboards', [])
 
+    interface_type = _get_interface_type(description)
+
     if len(dashboards) == 0:
-        return ifc
+        return {
+            **ifc,
+            'dashboard_info': {
+                'name': description,
+                'interface_type': interface_type.name
+            }
+        }
 
     if BRIAN_DASHBOARDS.INFRASTRUCTURE_BACKBONE.name in dashboards:
         name = description.split('|')