Skip to content
Snippets Groups Projects

remove import typing

Merged Karel van Klink requested to merge feature/remove-typing-import into develop
2 files
+ 6
9
Compare changes
  • Side-by-side
  • Inline
Files
2
+ 5
7
"""Routes for handling events related to the IP trunk service."""
"""Routes for handling events related to the IP trunk service."""
from os import path
from os import path
from typing import Optional
from fastapi import APIRouter
from fastapi import APIRouter
from pydantic import BaseModel, HttpUrl
from pydantic import BaseModel, HttpUrl
@@ -30,7 +29,7 @@ class IPTrunkProvisioningParams(IPTrunkParams):
@@ -30,7 +29,7 @@ class IPTrunkProvisioningParams(IPTrunkParams):
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: also making it an optional parameter.
#: also making it an optional parameter.
dry_run: Optional[bool] = True
dry_run: bool | None = True
#: The type of object that is changed.
#: The type of object that is changed.
object: str
object: str
@@ -40,7 +39,7 @@ class IPTrunkModifyParams(IPTrunkParams):
@@ -40,7 +39,7 @@ class IPTrunkModifyParams(IPTrunkParams):
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: also making it an optional parameter.
#: also making it an optional parameter.
dry_run: Optional[bool] = True
dry_run: bool | None = True
#: The old subscription object, represented as a dictionary. This allows
#: The old subscription object, represented as a dictionary. This allows
#: for calculating the difference in subscriptions.
#: for calculating the difference in subscriptions.
old_subscription: dict
old_subscription: dict
@@ -51,7 +50,7 @@ class IPTrunkMigrationParams(IPTrunkParams):
@@ -51,7 +50,7 @@ class IPTrunkMigrationParams(IPTrunkParams):
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: also making it an optional parameter.
#: also making it an optional parameter.
dry_run: Optional[bool] = True
dry_run: bool | None = True
#: The new Router that this IP Trunk is migrating to.
#: The new Router that this IP Trunk is migrating to.
new_side: dict
new_side: dict
#: An Ansible playbook verb that is passed along for indicating the phase of the migration that is performed.
#: An Ansible playbook verb that is passed along for indicating the phase of the migration that is performed.
@@ -72,7 +71,7 @@ class IPTrunkDeleteParams(IPTrunkParams):
@@ -72,7 +71,7 @@ class IPTrunkDeleteParams(IPTrunkParams):
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: Whether this playbook execution should be a dry run, or run for real. Defaults to ``True`` for obvious reasons,
#: also making it an optional parameter.
#: also making it an optional parameter.
dry_run: Optional[bool] = True
dry_run: bool | None = True
@router.post("/")
@router.post("/")
@@ -217,8 +216,7 @@ def migrate_ip_trunk(params: IPTrunkMigrationParams) -> PlaybookLaunchResponse:
@@ -217,8 +216,7 @@ def migrate_ip_trunk(params: IPTrunkMigrationParams) -> PlaybookLaunchResponse:
"verb": params.verb,
"verb": params.verb,
"config_object": params.config_object,
"config_object": params.config_object,
"dry_run": str(params.dry_run),
"dry_run": str(params.dry_run),
"commit_comment": f"GSO_PROCESS_ID: {params.process_id} "
"commit_comment": f"GSO_PROCESS_ID: {params.process_id} - TT_NUMBER: {params.tt_number}"
f"- TT_NUMBER: {params.tt_number}"
f"- Deploy config for {params.subscription['iptrunk']['geant_s_sid']} ",
f"- Deploy config for {params.subscription['iptrunk']['geant_s_sid']} ",
}
}
Loading