Skip to content
Snippets Groups Projects

Clean up the repo a bit, and add some unit tests

Merged Karel van Klink requested to merge feature/add-unit-tests into develop
All threads resolved!
  • Add a bunch of unit tests for different workflows
  • Rework the different util modules and merge them where relevant
  • Resolve some TODO items in config.py (netmasks are now validated)
  • Add some :term: directives to docstrings
  • Resolve a pytest warning about an unregistered mark @pytest.mask.workflow

Merge request reports

Pipeline #84245 passed

Pipeline passed for 8701ab80 on feature/add-unit-tests

Merged by Neda MoeiniNeda Moeini 1 year ago (Oct 19, 2023 11:39am UTC)

Merge details

  • Changes merged into with 8701ab80.
  • Deleted the source branch.

Pipeline #84246 passed

Pipeline passed for 8701ab80 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Neda Moeini approved this merge request

    approved this merge request

  • Karel van Klink added 5 commits

    added 5 commits

    • 438316c0 - update iptrunk service model
    • dc24f4f8 - update IPtrunk product block where the list of LAG members is a separate product block
    • 63f9ba4b - add unit test for iptrunk termination, kicking us over the limit of 80% coverage
    • 1910a3c7 - update iptrunk modification unit test
    • 2322f3bd - move types into their respective product blocks and types

    Compare with previous version

  • Karel van Klink mentioned in merge request !84 (closed)

    mentioned in merge request !84 (closed)

  • Karel van Klink resolved all threads

    resolved all threads

  • Karel van Klink added 23 commits

    added 23 commits

    • 2322f3bd...9e47b8df - 5 commits from branch develop
    • 9e47b8df...95dd5fa8 - 8 earlier commits
    • e98da87f - add unit test for router creation
    • 0a08e5b4 - split off reused method to __init__ module, update router creation test
    • 87337cf9 - add unit test for router termination workflow
    • 56194f6a - add unit test for iptrunk modify ISIS metric workflow
    • 0af11206 - add (unfinished) unit test for iptrunk interface modification workflow
    • c790ca17 - update iptrunk service model
    • 0a858f0b - update IPtrunk product block where the list of LAG members is a separate product block
    • 9d42ecd9 - add unit test for iptrunk termination, kicking us over the limit of 80% coverage
    • af7e59b5 - update iptrunk modification unit test
    • 35e17e93 - move types into their respective product blocks and types

    Compare with previous version

  • I will need to spend some time on integrating the new tests, the IPtrunk remodel, and the Netbox functinoality. For now however, I will enjoy my weekend :slight_smile:

  • Karel van Klink added 1 commit

    added 1 commit

    • 6b1c3880 - integrate the iptrunk model rework and netbox functionality

    Compare with previous version

  • Neda Moeini added 1 commit

    added 1 commit

    • 4b8c54c1 - Fixed interface list drop down.

    Compare with previous version

  • Neda Moeini added 1 commit

    added 1 commit

    • 265e0a10 - Moved exceptions to a general exception module.

    Compare with previous version

  • Neda Moeini added 22 commits

    added 22 commits

    • af39ed7c - 1 commit from branch develop
    • af39ed7c...17a71b7b - 11 earlier commits
    • bfa64232 - add unit test for iptrunk modify ISIS metric workflow
    • 162dc793 - add (unfinished) unit test for iptrunk interface modification workflow
    • 3a90b9ce - update iptrunk service model
    • 459af11f - update IPtrunk product block where the list of LAG members is a separate product block
    • c6288e2e - add unit test for iptrunk termination, kicking us over the limit of 80% coverage
    • 60355082 - update iptrunk modification unit test
    • 93683d92 - move types into their respective product blocks and types
    • f86c1fc5 - integrate the iptrunk model rework and netbox functionality
    • 51d33a1a - Fixed interface list drop down.
    • 8701ab80 - Moved exceptions to a general exception module.

    Compare with previous version

  • Neda Moeini enabled an automatic merge when the pipeline for 8701ab80 succeeds

    enabled an automatic merge when the pipeline for 8701ab80 succeeds

  • merged

  • Please register or sign in to reply
    Loading