Skip to content
Snippets Groups Projects

Feature/update input form validation

Closed Karel van Klink requested to merge feature/update-input-form-validation into develop
All threads resolved!

Update the input forms for site and router creation.

Changes:

  • Site country code must exist
  • TS server address must be valid
  • Router TS port must be valid
  • Site latitude and longitude must make sense (-90 < x < 90 and -180 < y < 180)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karel van Klink resolved all threads

    resolved all threads

  • Karel van Klink added 2 commits

    added 2 commits

    • 2557d648 - apply feedback, mostly remove redundant comments
    • 9818590e - update documentation

    Compare with previous version

  • Simone Spinelli approved this merge request

    approved this merge request

  • Karel van Klink added 14 commits

    added 14 commits

    • 9818590e...a1228219 - 10 commits from branch develop
    • 7e6d7195 - add validators to site creation workflow
    • 0df0db53 - add validators to router creation workflow, also making IAS connection optional
    • c1b72878 - apply feedback, mostly remove redundant comments
    • 9c3c6f8d - update documentation

    Compare with previous version

  • Karel van Klink enabled an automatic merge when the pipeline for 9c3c6f8d succeeds

    enabled an automatic merge when the pipeline for 9c3c6f8d succeeds

  • Mohammad Torkashvand approved this merge request

    approved this merge request

  • Karel van Klink aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Karel van Klink added 6 commits

    added 6 commits

    • 4b23e274 - add validators to site creation workflow
    • 23c78aa9 - add validators to router creation workflow, also making IAS connection optional
    • 2557d648 - apply feedback, mostly remove redundant comments
    • 9818590e - update documentation
    • f9022eb1 - Merge remote-tracking branch 'origin/feature/update-input-form-validation'...
    • 7fc26555 - update router import to use a PortNumber

    Compare with previous version

  • Karel van Klink added 1 commit

    added 1 commit

    • e288e3f8 - update router import to use a PortNumber

    Compare with previous version

  • This will be part of a new MR which merges feature/ip-trunk-migration

  • Please register or sign in to reply
    Loading