SDP mesh functions

• Externalized update_sdp_mesh_dry and _real into workflow_steps
• Added _update_sdp_single_pe into workflow_steps
• Added necessary imports

@karel.vanklink Maybe _update_sdp_mesh and _update_sdp_single_pe can be optimized? The only difference in them is that inventory and pe_router_list in extra_vars are swapped.

approved this merge request

LGTM

added 9 commits

• 96ec5d43 - Increase initial connection timeout for LibreNMS client
• ec352a1a - Change type from LAGMember to dict for workflow step in trunk modification
• 0ee4de7e - make celery concurrency level 1
• ccb850d9 - incremented version for next development iteration
• eb52a306 - Edit changelog for version 2.13
• 029e1e87 - Include original exception when logging an error in the infoblox client
• a0518cfe - incremented version for next development iteration
• a1b7592c - Update Changelog.md
• 1e30ade7 - Show current license usage when updating Kentik license of a router

Compare with previous version

added 3 commits

• ef7e1874 - add PE-P and PE-PE mesh functions to workflow_steps
• 7f59e7ca - add PE-only steps to update_ibgp_mesh
• 6977db07 - externalized PE functions in promote_p_to_pe

Compare with previous version

added 18 commits

• 6977db07...65e88e3d - 13 commits from branch develop
• 03d0fcda - SDP mesh functions
• f71c9abb - Update imports and formatting
• 80343575 - add PE-P and PE-PE mesh functions to workflow_steps
• 30729590 - add PE-only steps to update_ibgp_mesh
• 4bdc2aad - externalized PE functions in promote_p_to_pe

Compare with previous version

@karel.vanklink I need your help with test_update_ibgp_mesh.py to account for the changes in the workflow itself.

@simone.spinelli Please could you review:

• workflows/router/update_ibgp_mesh
• utils/workflow_steps (for details)

requested review from @simone.spinelli

We might at some point want to refactor the way we keep re-usable workflow steps, since the file is getting rather large and hard to keep track of. Not something for now, but something to keep in mind

added 1 commit

• 9ea08606 - Reflect workflow changes in unit test for SDP update

Compare with previous version

@karel.vanklink Thanks for the fixes. There is another problem I forgot to mention: When the generated inventory is "empty", the Ansible hangs. E.g. in _update_sdp_mesh:

    inventory = generate_inventory_for_active_routers(
        router_role=RouterRole.PE, router_vendor=Vendor.NOKIA, exclude_routers=[subscription["router"]["router_fqdn"]]
    )

The corner case is that the router that is being processed in the workflow is the first ever Nokia PE, and it is correctly excluded from the inventory, then the resulting inventory is empty. Could a check be implemented in GSO such that in these cases of empty inventory a step would be skipped?

resolved all threads

added 1 commit

• 10cd77c4 - Put LSO interactions inside a step group to reduce GUI clutter

Compare with previous version

added 1 commit

• 4edfd5aa - Add example skip playbook if inventory is empty

Compare with previous version

@Aleksandr.Kurbatov I wasn't able to find a way to automatically skip based on an empty inventory, but I added a line to _update_sbp_mesh() that might set you off in the right direction. Do note that I didn't test this properly

added 1 commit

• 064275e4 - Add example skip playbook if inventory is empty

Compare with previous version

added 2 commits

• 7c3ebd0c - Resync with develop and changes to workflow_steps, promote_p_to_pe, update_ibgp_mesh
• 59e350ea - lso_client - resync with develop

Compare with previous version

added 1 commit

• 34ecda72 - Updates to workflow_steps and promote_p_to_pe

Compare with previous version

closed