Skip to content
Snippets Groups Projects

Skip IP trunk validation for trunks that are Juniper on both sides

Merged Karel van Klink requested to merge feature/fix-legacy-trunk-validation into develop
All threads resolved!
2 files
+ 83
3
Compare changes
  • Side-by-side
  • Inline
Files
2
@@ -5,7 +5,7 @@ import json
from orchestrator.targets import Target
from orchestrator.utils.errors import ProcessFailureError
from orchestrator.utils.json import json_dumps
from orchestrator.workflow import StepList, begin, done, step, workflow
from orchestrator.workflow import StepList, begin, conditional, done, step, workflow
from orchestrator.workflows.steps import resync, store_process_subscription, unsync
from orchestrator.workflows.utils import wrap_modify_initial_input_form
@@ -192,10 +192,20 @@ def validate_iptrunk() -> StepList:
* Verify the configuration on both sides of the trunk is intact.
* Check the ISIS metric of the trunk.
* Verify that TWAMP configuration is correct.
If a trunk has a Juniper router on both sides, it is considered legacy and does not require validation.
"""
is_legacy_trunk = conditional(
lambda state: all(
side.iptrunk_side_node.vendor == Vendor.JUNIPER
for side in Iptrunk.from_subscription(state["subscription_id"]).iptrunk.iptrunk_sides
)
)
return (
begin
>> store_process_subscription(Target.SYSTEM)
>> is_legacy_trunk(done)
>> unsync
>> verify_ipam_records
>> verify_netbox_entries
Loading