Skip to content
Snippets Groups Projects
Commit 563065d2 authored by Hakan Calim's avatar Hakan Calim
Browse files

NAT-286: Fixed get_all_lags test

parent d3ea4aff
Branches
Tags
1 merge request!89Feature/nat 286 create unit tests for netbox client
Pipeline #84249 failed
...@@ -53,24 +53,21 @@ def card_type(): ...@@ -53,24 +53,21 @@ def card_type():
@pytest.fixture(scope="module") @pytest.fixture(scope="module")
def interface(): def interface():
values = {"id": 1, values = {
"name": "et-0/0/1", "id": 1,
"speed": 1000, "name": "et-0/0/1",
"type": "1000BaseT", "speed": 1000,
"enabled": False, "type": "1000BaseT",
"mark_connected": False} "enabled": False,
"mark_connected": False,
}
return Record(values, None, None) return Record(values, None, None)
@patch("gso.services.netbox_client.pynetbox.api") @patch("gso.services.netbox_client.pynetbox.api")
def test_create_device(mock_api, def test_create_device(
device, mock_api, device, device_type, device_role, site, device_bay, card_type, data_config_filename: PathLike
device_type, ):
device_role,
site,
device_bay,
card_type,
data_config_filename: PathLike):
device_name = "mx1.lab.geant.net" device_name = "mx1.lab.geant.net"
device.name = device_name device.name = device_name
site_tier = SiteTier.TIER1 site_tier = SiteTier.TIER1
...@@ -93,7 +90,7 @@ def test_create_device(mock_api, ...@@ -93,7 +90,7 @@ def test_create_device(mock_api,
@patch("gso.services.netbox_client.pynetbox.api") @patch("gso.services.netbox_client.pynetbox.api")
def test_get_available_lags(mock_api, mock_from_subscription, data_config_filename: PathLike): def test_get_available_lags(mock_api, mock_from_subscription, data_config_filename: PathLike):
router_id = uuid.uuid4() router_id = uuid.uuid4()
feasible_lags = [f"LAG-{i}" for i in range(1, 10)] feasible_lags = [f"LAG-{i}" for i in range(1, 11)]
# Mock the pynetbox API instance # Mock the pynetbox API instance
mock_netbox = mock_api.return_value mock_netbox = mock_api.return_value
...@@ -119,10 +116,7 @@ def test_create_interface(mock_api, device, interface, data_config_filename: Pat ...@@ -119,10 +116,7 @@ def test_create_interface(mock_api, device, interface, data_config_filename: Pat
mock_api.return_value.dcim.interfaces.create.return_value = interface mock_api.return_value.dcim.interfaces.create.return_value = interface
# Create new interface # Create new interface
new_interface = NetboxClient().create_interface(interface.name, new_interface = NetboxClient().create_interface(interface.name, interface.type, interface.speed, device.name)
interface.type,
interface.speed,
device.name)
# Check result # Check result
assert new_interface is not None assert new_interface is not None
...@@ -145,7 +139,7 @@ def test_reserve_interface_exception(mock_api, device, interface, data_config_fi ...@@ -145,7 +139,7 @@ def test_reserve_interface_exception(mock_api, device, interface, data_config_fi
mock_api.return_value.dcim.devices.get.return_value = device mock_api.return_value.dcim.devices.get.return_value = device
mock_api.return_value.dcim.interfaces.get.return_value = interface mock_api.return_value.dcim.interfaces.get.return_value = interface
# Check exception # Check exception
with pytest.raises(WorkflowStateError) as test_exception: with pytest.raises(WorkflowStateError) as test_exception:
NetboxClient().reserve_interface(device.name, interface.name) NetboxClient().reserve_interface(device.name, interface.name)
assert str(test_exception.value) == exception_message assert str(test_exception.value) == exception_message
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment