Skip to content
Snippets Groups Projects
Commit 0e2653d9 authored by Neda Moeini's avatar Neda Moeini
Browse files

used suppress instead of try-except.

parent a5596463
No related branches found
No related tags found
1 merge request!190Updated delete Netbox device functionality to delete the device if it exists...
Pipeline #86099 failed
"""Contain all methods to communicate with the NetBox API endpoint. Data Center Infrastructure Main (DCIM).""" """Contain all methods to communicate with the NetBox API endpoint. Data Center Infrastructure Main (DCIM)."""
from contextlib import suppress
from uuid import UUID from uuid import UUID
import pydantic import pydantic
...@@ -125,8 +126,9 @@ class NetboxClient: ...@@ -125,8 +126,9 @@ class NetboxClient:
def delete_interface(self, device_name: str, iface_name: str) -> None: def delete_interface(self, device_name: str, iface_name: str) -> None:
"""Delete an interface from a device by name.""" """Delete an interface from a device by name."""
interface = self.get_interface_by_name_and_device(iface_name, device_name) interface = self.get_interface_by_name_and_device(iface_name, device_name)
if interface is not None: if interface:
return interface.delete() return interface.delete()
return None
def create_device_type(self, manufacturer: str, model: str, slug: str) -> DeviceTypes: def create_device_type(self, manufacturer: str, model: str, slug: str) -> DeviceTypes:
"""Create a new device type in Netbox.""" """Create a new device type in Netbox."""
...@@ -199,10 +201,8 @@ class NetboxClient: ...@@ -199,10 +201,8 @@ class NetboxClient:
def delete_device(self, device_name: str) -> None: def delete_device(self, device_name: str) -> None:
"""Delete device by name if exists.""" """Delete device by name if exists."""
try: with suppress(AttributeError):
self.netbox.dcim.devices.get(name=device_name).delete() self.netbox.dcim.devices.get(name=device_name).delete()
except AttributeError:
pass
def attach_interface_to_lag( def attach_interface_to_lag(
self, self,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment