Add config_mode private to junos_config module

Closes NAT-1223

assigned to @mohammad.torkashvand

added 1 commit

• 98b4b3de - Add config_mode private to junos_config module

Compare with previous version

@simone.spinelli I added this function and the original one is here. Actually I replaced all locked_config with my safe_locked_config

@contextmanager
def locked_config(module):
    try:
        lock_configuration(module)
        yield
    finally:
        unlock_configuration(module)

requested review from @simone.spinelli

and this is also me!

I replaced locked_config with mine safe_locked_config and did this everywhere in this file

these 2 imports are also me

So you practically imported the whole junos_config role (the "old one") and added few tweaks like safe_unlock?

If you mean this repo https://github.com/ansible-collections/junipernetworks.junos, Yes!

But the RPC part is the one from ansible. Correct?

No, conn.execute_rpc is also part of junipernetworks.junos, but to be strictly accurate, under the hood it uses the Connection class from ansible.module_utils.connection.

and these are also something that I found in Juniper docs

Element("close-configuration",
{"xmlns": "http://xml.juniper.net/xnm/1.1/xnm"}\ )

and

Element("open-configuration",
{"xmlns": "http://xml.juniper.net/xnm/1.1/xnm",\ "private": "true"}
)

approved this merge request

All clear after @mohammad.torkashvand walked me though.

merged

mentioned in commit a3954f7e