`ansible_connection` in ibgp_update

geant/gap_ansible/roles/ibgp_update/tasks/check_nokia_ibgp.yaml

 - name: Set variable to connect to nokia
   ansible.legacy.set_fact:
-    ansible_network_os: nokia.sros.md
-    ansible_connection: netconf
+    ansible_connection: "{{ netconf_access[wfo_router.router.vendor].ansible_connection }}"
+    ansible_network_os: "{{ netconf_access[wfo_router.router.vendor].ansible_network_os }}"
 
 - name: Check BGP status
   block:

geant/gap_ansible/roles/ibgp_update/tasks/compile.yaml

@@ -26,7 +26,7 @@
 - name: Set back ansible_host to target terminal server
   ansible.builtin.set_fact:
     ansible_host: "{{ wfo_router.router.router_site.site_ts_address }}"
-    ansible_connection: netconf
+    ansible_connection: "{{ netconf_access[wfo_router.router.vendor].ansible_connection }}"
   when:
     wfo_router.router.router_access_via_ts is defined and
     ( wfo_router.router.router_access_via_ts | ansible.builtin.bool ) is true

geant/gap_ansible/roles/ibgp_update/tasks/modify_router_list.yaml

@@ -3,18 +3,9 @@
 # PEs can be either Juniper or Nokia
 
 - name: Adjust network connection according to the vendor
-  block:
-    - name: Set variable to connect to nokia
-      ansible.legacy.set_fact:
-        ansible_network_os: geant.gap_ansible.sros
-        ansible_connection: netconf
-      when: vendor == "nokia"
-
-    - name: Set variables for connecting to Junos
-      ansible.legacy.set_fact:
-        ansible_network_os: junos
-        ansible_connection: netconf
-      when: vendor == "juniper"
+  ansible.builtin.set_fact:
+    ansible_connection: "{{ netconf_access[wfo_router.router.vendor].ansible_connection }}"
+    ansible_network_os: "{{ netconf_access[wfo_router.router.vendor].ansible_network_os }}"
 
 - name: Include compile tasks
   ansible.builtin.include_tasks: compile.yaml

geant/gap_ansible/roles/ibgp_update/tasks/modify_subscription_router.yaml

@@ -2,12 +2,11 @@
 # We need to add all the existing PE the new P
 # P routers will always be NOKIA
 # In this case you have wfo_router as external variable
-# FIX: Load ansible_network_os via group_vars
 #
 - name: Set variable to connect to nokia
   ansible.builtin.set_fact:
-    ansible_network_os: geant.gap_ansible.sros
-    ansible_connection: netconf
+    ansible_connection: "{{ netconf_access[subscription.router.vendor].ansible_connection }}"
+    ansible_network_os: "{{ netconf_access[subscription.router.vendor].ansible_network_os }}"
 
 - name: Set ansible_host to terminal server when router is offline
   ansible.builtin.set_fact: