Merge branch 'base_config_update' into 'develop'

remote user should be now passed as environmental var

See merge request !106

geant/gap_ansible/playbooks/base_config.yaml

 - name: Manage base config playbook
   hosts: all
   gather_facts: false
-  remote_user: admin
+  # remote_user: admin
+  # remote_user: geant-gap-test
   roles:
     - Juniper.junos
     - ../roles/base_config

geant/gap_ansible/roles/base_config/tasks/deploy_base_config.yaml

 - name: Deploy base_config on "{{ inventory_hostname }}" [CHECK ONLY][Juniper]
-  juniper_junos_config:
-    load: 'replace'
+  junipernetworks.junos.junos_config:
+    update: 'replace'
     src: "/var/tmp/ansible_run_{{ opid }}/{{ mytemplates.template_name }}.conf"
-    format: text
-    config_mode: "private"
-    check: true
-    commit: false
-  register: response
+    src_format: text
+    check_commit: true
+  diff: true
   when: >
     verb == "deploy" and
     ( dry_run | ansible.builtin.bool ) is true and
     wfo_router.router.vendor == "juniper"
 
-- name: Show diff for dry run
-  ansible.builtin.debug:
-    msg: "{{ response }}"
-  when: >
-    verb == "deploy" and
-    ( dry_run | ansible.builtin.bool ) is true and
-    wfo_router.router.vendor == "juniper"
 
 - name: Deploy base_config on "{{ inventory_hostname }}" [AND COMMIT][Juniper]
-  juniper_junos_config:
-    load: 'replace'
+  junipernetworks.junos.junos_config:
+    update: 'replace'
     src: "/var/tmp/ansible_run_{{ opid }}/{{ mytemplates.template_name }}.conf"
-    format: text
-    config_mode: "private"
+    src_format: text
     comment: "{{ commit_comment }}"
   register: response
   when: >
@@ -33,13 +23,13 @@
     ( dry_run | ansible.builtin.bool ) is false and
     wfo_router.router.vendor == "juniper"
 
-- name: Show diff
-  ansible.builtin.debug:
-    msg: "{{ response }}"
-  when: >
-    verb == "deploy" and
-    ( dry_run | ansible.builtin.bool ) is false and
-    wfo_router.router.vendor == "juniper"
+# - name: Show diff
+#   ansible.builtin.debug:
+#     msg: "{{ response }}"
+#   when: >
+#     verb == "deploy" and
+#     ( dry_run | ansible.builtin.bool ) is false and
+#     wfo_router.router.vendor == "juniper"
 
 - name: Deploy base_config on "{{ inventory_hostname }}" [CHECK ONLY][NOKIA]
   ansible.netcommon.netconf_config:

geant/gap_ansible/roles/base_config/vars/main.yml

@@ -17,4 +17,4 @@ is_ias_connected: "{{ wfo_router.router.is_ias_connected }}"
 
 mytemplates:
   template_name: base_config
-  template_path: "routers/{{ wfo_router.vendor }}/base_config.j2"
+  template_path: "routers/{{ wfo_router.router.vendor }}/base_config.j2"

geant/gap_ansible/roles/base_config_checks/tasks/base_config_checks_juniper.yaml

+- name: Base config Juniper checks
+  juniernetworks.junos.junos_command:
+    commands:
+      - show version
+      - show system alarms

geant/gap_ansible/roles/base_config_checks/tasks/main.yml

@@ -20,6 +20,14 @@
   when:
     wfo_router.router.vendor == "juniper"
 
-- name: Execute post-check command
+- name: Execute post-check command [NOKIA]
+  when:
+    wfo_router.router.vendor == "nokia"
   ansible.builtin.include_tasks: base_config_single_command.yaml
   with_items: "{{ commands }}"
+
+- name: Execute post-check command [JUNIPER]
+  when:
+    wfo_router.router.vendor == "juniper"
+  ansible.builtin.include_tasks: base_config_checks_juniper.yaml
+  # with_items: "{{ commands }}"