Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
Sage Validation
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
geant-swd
Sage Validation
Merge requests
!7
Improve validation error handling for missing nominal analysis fields in CSV upload
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Improve validation error handling for missing nominal analysis fields in CSV upload
enhancement/dont-let-blank-field-for-nc-cc-dep-validation
into
develop
Overview
0
Commits
1
Pipelines
0
Changes
2
Merged
Neda Moeini
requested to merge
enhancement/dont-let-blank-field-for-nc-cc-dep-validation
into
develop
1 month ago
Overview
0
Commits
1
Pipelines
0
Changes
2
Expand
0
0
Merge request reports
Compare
develop
develop (base)
and
latest version
latest version
568c07d1
1 commit,
1 month ago
2 files
+
20
−
0
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
sage_validation/file_validator/forms.py
+
2
−
0
Options
@@ -245,6 +245,8 @@ class CSVUploadForm(forms.Form):
nominal_account_name
=
row
.
get
(
nominal_account_field
)
if
not
cc
or
not
dep
or
not
nominal_account_name
:
errors
.
append
(
f
"
Row
{
index
}
: Missing values in
'
{
cc_field
}
'
,
'
{
dep_field
}
'
, or
"
f
"'
{
nominal_account_field
}
'
.
"
)
continue
cc_type
=
cost_centre_map
.
get
(
cc
)
Loading