Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found
Select Git revision
  • develop
  • master
  • 0.1
  • 0.10
  • 0.11
  • 0.12
  • 0.2
  • 0.3
  • 0.4
  • 0.5
  • 0.6
  • 0.8
  • 0.9
13 results

Target

Select target project
  • geant-swd/sage-validation
1 result
Select Git revision
  • develop
  • master
  • 0.1
  • 0.10
  • 0.11
  • 0.12
  • 0.2
  • 0.3
  • 0.4
  • 0.5
  • 0.6
  • 0.8
  • 0.9
13 results
Show changes
Commits on Source (2)
......@@ -245,10 +245,10 @@ class CSVUploadForm(forms.Form):
nominal_account_name = row.get(nominal_account_field)
if not cc and not dep and not nominal_account_name:
errors.append(
f"Row {index}: Missing values in '{cc_field}', '{dep_field}', and '{nominal_account_field}'.")
continue
if not cc or not dep or not nominal_account_name:
errors.append(
f"Row {index}: Missing values in '{cc_field}', '{dep_field}', or '{nominal_account_field}'.")
continue
cc_type = cost_centre_map.get(cc)
......
......@@ -102,14 +102,13 @@ def test_validate_nc_cc_dep_combination_against_meo_sage_account_blank_values(
{
"NominalAnalysisNominalCostCentre/1": "",
"NominalAnalysisNominalDepartment/1": "",
"NominalAnalysisNominalAccountNumber/1": ""
})
form = CSVUploadForm(files={"file": modified_file})
assert not form.is_valid()
assert (
"Row 1: Missing values in 'NominalAnalysisNominalCostCentre/1', 'NominalAnalysisNominalDepartment/1',"
" and 'NominalAnalysisNominalAccountNumber/1'."
" or 'NominalAnalysisNominalAccountNumber/1'."
in str(form.errors["file"][0])
)
......