Skip to content
Snippets Groups Projects
Commit a7c98797 authored by Neda Moeini's avatar Neda Moeini
Browse files

Change the NC_CC_DEP validation error handling

parent 9eab6a56
Branches
Tags
1 merge request!9Change the NC_CC_DEP validation error handling
...@@ -245,10 +245,10 @@ class CSVUploadForm(forms.Form): ...@@ -245,10 +245,10 @@ class CSVUploadForm(forms.Form):
nominal_account_name = row.get(nominal_account_field) nominal_account_name = row.get(nominal_account_field)
if not cc and not dep and not nominal_account_name: if not cc and not dep and not nominal_account_name:
errors.append(
f"Row {index}: Missing values in '{cc_field}', '{dep_field}', and '{nominal_account_field}'.")
continue continue
if not cc or not dep or not nominal_account_name: if not cc or not dep or not nominal_account_name:
errors.append(
f"Row {index}: Missing values in '{cc_field}', '{dep_field}', or '{nominal_account_field}'.")
continue continue
cc_type = cost_centre_map.get(cc) cc_type = cost_centre_map.get(cc)
......
...@@ -102,14 +102,13 @@ def test_validate_nc_cc_dep_combination_against_meo_sage_account_blank_values( ...@@ -102,14 +102,13 @@ def test_validate_nc_cc_dep_combination_against_meo_sage_account_blank_values(
{ {
"NominalAnalysisNominalCostCentre/1": "", "NominalAnalysisNominalCostCentre/1": "",
"NominalAnalysisNominalDepartment/1": "", "NominalAnalysisNominalDepartment/1": "",
"NominalAnalysisNominalAccountNumber/1": ""
}) })
form = CSVUploadForm(files={"file": modified_file}) form = CSVUploadForm(files={"file": modified_file})
assert not form.is_valid() assert not form.is_valid()
assert ( assert (
"Row 1: Missing values in 'NominalAnalysisNominalCostCentre/1', 'NominalAnalysisNominalDepartment/1'," "Row 1: Missing values in 'NominalAnalysisNominalCostCentre/1', 'NominalAnalysisNominalDepartment/1',"
" and 'NominalAnalysisNominalAccountNumber/1'." " or 'NominalAnalysisNominalAccountNumber/1'."
in str(form.errors["file"][0]) in str(form.errors["file"][0])
) )
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment