Skip to content
Snippets Groups Projects

normalization of nrens including datamigration

Merged Remco Tukker requested to merge feature/COMP-128_normalize_NRENs into develop
All threads resolved!

normalization of nrens including datamigration The NREN list is hardcoded in the db migration and no new NRENs are made automatically (the db migration crashes if an unknown NREN is found, the excel importers emit a warning and skip the entry). Some NRENs have old or alternative names, which is taken into account in the db migration file and in the publishers helpers.py file.

Edited by Remco Tukker

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bjarke Madsen
  • @remco.tukker looks good to me, I've added a few comments mostly related to the NREN mapping

  • Remco Tukker added 2 commits

    added 2 commits

    • 1d23bf05 - linelength to 80 and updates to the correct NREN names
    • 32700ee5 - updated NREN list

    Compare with previous version

  • Remco Tukker changed the description

    changed the description

  • Remco Tukker marked this merge request as ready

    marked this merge request as ready

  • Remco Tukker resolved all threads

    resolved all threads

  • Remco Tukker mentioned in commit 2d98296b

    mentioned in commit 2d98296b

  • merged

  • Please register or sign in to reply
    Loading