Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
B
brian-polling-manager
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
geant-swd
brian
brian-polling-manager
Commits
3f30b089
Commit
3f30b089
authored
1 year ago
by
Erik Reid
Browse files
Options
Downloads
Patches
Plain Diff
fixed some broken tests (fixed merge conflicts)
parent
9bb7ea5c
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
test/interface_stats/conftest.py
+11
-0
11 additions, 0 deletions
test/interface_stats/conftest.py
with
11 additions
and
0 deletions
test/interface_stats/conftest.py
+
11
−
0
View file @
3f30b089
...
@@ -70,16 +70,27 @@ def all_nokia_routers():
...
@@ -70,16 +70,27 @@ def all_nokia_routers():
return
NOKIA_ROUTERS
return
NOKIA_ROUTERS
"""
@pelle: having a fixture that is used only in one place, and in a
separate file from where it is used only decreases readability.
Please move it ... or (to minimize ambiguity) use pytest.mark.parametrize
(this and the one below)
"""
@pytest.fixture
(
params
=
JUNIPER_ROUTERS
)
@pytest.fixture
(
params
=
JUNIPER_ROUTERS
)
def
juniper_router_fqdn
(
request
):
def
juniper_router_fqdn
(
request
):
return
request
.
param
return
request
.
param
@pytest.fixture
(
params
=
NOKIA_ROUTERS
)
def
nokia_router_fqdn
(
request
):
return
request
.
param
@pytest.fixture
(
params
=
NOKIA_ROUTERS
)
@pytest.fixture
(
params
=
NOKIA_ROUTERS
)
def
nokia_router_fqdn
(
request
):
def
nokia_router_fqdn
(
request
):
return
request
.
param
return
request
.
param
@pytest.fixture
()
@pytest.fixture
()
def
single_router_fqdn
():
def
single_router_fqdn
():
return
JUNIPER_ROUTERS
[
0
]
return
JUNIPER_ROUTERS
[
0
]
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment