Skip to content
Snippets Groups Projects
Commit 3f30b089 authored by Erik Reid's avatar Erik Reid
Browse files

fixed some broken tests (fixed merge conflicts)

parent 9bb7ea5c
No related branches found
No related tags found
No related merge requests found
...@@ -70,16 +70,27 @@ def all_nokia_routers(): ...@@ -70,16 +70,27 @@ def all_nokia_routers():
return NOKIA_ROUTERS return NOKIA_ROUTERS
"""
@pelle: having a fixture that is used only in one place, and in a
separate file from where it is used only decreases readability.
Please move it ... or (to minimize ambiguity) use pytest.mark.parametrize
(this and the one below)
"""
@pytest.fixture(params=JUNIPER_ROUTERS) @pytest.fixture(params=JUNIPER_ROUTERS)
def juniper_router_fqdn(request): def juniper_router_fqdn(request):
return request.param return request.param
@pytest.fixture(params=NOKIA_ROUTERS)
def nokia_router_fqdn(request):
return request.param
@pytest.fixture(params=NOKIA_ROUTERS) @pytest.fixture(params=NOKIA_ROUTERS)
def nokia_router_fqdn(request): def nokia_router_fqdn(request):
return request.param return request.param
@pytest.fixture() @pytest.fixture()
def single_router_fqdn(): def single_router_fqdn():
return JUNIPER_ROUTERS[0] return JUNIPER_ROUTERS[0]
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment