enforce strict and warnings pragmas usage

bin/account-manager-client.pl

@@ -8,6 +8,7 @@
 ## Command-line client for the Test IdP Account Manager
 
 use strict;
+use warnings;
 use utf8;
 use lib qw(lib conf);
 

bin/account-manager-web.pl

@@ -7,7 +7,8 @@
 ## 15/09/2014, Olivier Salaün
 ## Web interface for the eduGAIN Access Check Account Manager
 
-use strict vars;
+use strict;
+use warnings;
 use utf8;
 use lib qw(lib conf);
 
@@ -153,11 +154,10 @@ sub execute {
         delete $self->{'next_action'};    ## Prevent loops
 
         if (defined $actions{ $self->{'action'} }) {
-
             ## Execute the target subroutine named req_actionName
+            no strict 'refs';
             my $sub = 'req_' . $self->{'action'};
             $status = &{$sub}($self);
-
         } else {
             ## Inknown action
             push @{ $self->{'param_out'}{'errors'} }, "unknown_action";

bin/create-database-code.pl

 #!/usr/bin/perl
 ## Initialize Rose::DB code given the DB structure
 
+use strict;
+use warnings;
 use lib qw(lib conf);
 
 use Rose::DB;

lib/IdPAccountManager/AuthenticationToken.pm

@@ -5,6 +5,7 @@ package IdPAccountManager::AuthenticationToken;
 ## from the European Community¹s Seventh Framework Programme (FP7/2007-2013) under grant agreement nº 238875 (GÉANT).
 
 use strict;
+use warnings;
 
 use IdPAccountManager::Data::Authenticationtoken;
 use IdPAccountManager::Data::Authenticationtoken::Manager;

lib/IdPAccountManager/DB.pm

 package IdPAccountManager::DB;
 
 use strict;
+use warnings;
 
 use base 'Rose::DB';
 

lib/IdPAccountManager/DB/Object.pm

 package IdPAccountManager::DB::Object;
 
+use strict;
+use warnings;
 use base 'Rose::DB::Object';
 
 use IdPAccountManager::DB;

lib/IdPAccountManager/Data/Authenticationtoken.pm

 package IdPAccountManager::Data::Authenticationtoken;
 
 use strict;
+use warnings;
 
 use base 'IdPAccountManager::DB::Object';
 

lib/IdPAccountManager/Data/Authenticationtoken/Manager.pm

 package IdPAccountManager::Data::Authenticationtoken::Manager;
 
 use strict;
+use warnings;
 
 use base qw(Rose::DB::Object::Manager);
 

lib/IdPAccountManager/Data/DB/Object/AutoBase2.pm

-package IdPAccountManager::Data::DB::Object::AutoBase2;
-
-use base 'Rose::DB::Object';
-
-use IdPAccountManager::Data::DB::AutoBase1;
-
-sub init_db { IdPAccountManager::Data::DB::AutoBase1->new }
-
-1;

lib/IdPAccountManager/Data/Serviceprovider.pm

 package IdPAccountManager::Data::Serviceprovider;
 
 use strict;
+use warnings;
 
 use base 'IdPAccountManager::DB::Object';
 

lib/IdPAccountManager/Data/Serviceprovider/Manager.pm

 package IdPAccountManager::Data::Serviceprovider::Manager;
 
 use strict;
+use warnings;
 
 use base qw(Rose::DB::Object::Manager);
 

lib/IdPAccountManager/Data/Testaccount.pm

 package IdPAccountManager::Data::Testaccount;
 
 use strict;
+use warnings;
 
 use base 'IdPAccountManager::DB::Object';
 

lib/IdPAccountManager/Data/Testaccount/Manager.pm

 package IdPAccountManager::Data::Testaccount::Manager;
 
 use strict;
+use warnings;
 
 use base qw(Rose::DB::Object::Manager);
 

lib/IdPAccountManager/SAMLMetadata.pm

@@ -5,6 +5,7 @@ package IdPAccountManager::SAMLMetadata;
 ## from the European Community¹s Seventh Framework Programme (FP7/2007-2013) under grant agreement nº 238875 (GÉANT).
 
 use strict;
+use warnings;
 
 use IdPAccountManager::Tools;
 use Conf;

lib/IdPAccountManager/ServiceProvider.pm

 package IdPAccountManager::ServiceProvider;
-use base 'IdPAccountManager::Data::Serviceprovider';
 
 ## Copyright (c) GEANT
 ## This software was developed by RENATER. The research leading to these results has received funding
 ## from the European Community¹s Seventh Framework Programme (FP7/2007-2013) under grant agreement nº 238875 (GÉANT).
 
 use strict;
+use warnings;
+
+use base 'IdPAccountManager::Data::Serviceprovider';
 
 use IdPAccountManager::Data::Serviceprovider;
 use IdPAccountManager::Data::Serviceprovider::Manager;

lib/IdPAccountManager/TestAccount.pm

@@ -5,6 +5,7 @@ package IdPAccountManager::TestAccount;
 ## from the European Community¹s Seventh Framework Programme (FP7/2007-2013) under grant agreement nº 238875 (GÉANT).
 
 use strict;
+use warnings;
 
 use IdPAccountManager::Data::Testaccount;
 use IdPAccountManager::Data::Testaccount::Manager;