short-circuit stash for those variables

lib/AccessCheck/App/Step1.pm

@@ -14,17 +14,14 @@ sub run {
     my $config = $app->config();
     my $log    = $app->log();
 
-    $self->init_l10n();
-    $self->init_user();
-    $self->init_db();
+    my $l10n = $self->init_l10n();
+    my $user = $self->init_user();
+    my $db   = $self->init_db();
 
     if ($config->{app}->{login_url}) {
         return if !$self->check_authentication();
     }
 
-    my $user = $self->stash('user');
-    my $db   = $self->stash('db');
-
     my $sps = AccessCheck::Data::Entity->get_entities(
         db    => $db,
         query => [

lib/AccessCheck/App/Step2.pm

@@ -12,9 +12,9 @@ sub run {
     my $config = $app->config();
     my $log    = $app->log();
 
-    $self->init_l10n();
-    $self->init_user();
-    $self->init_db();
+    my $l10n = $self->init_l10n();
+    my $user = $self->init_user();
+    my $db   = $self->init_db();
 
     if ($config->{app}->{login_url}) {
         return if !$self->check_authentication();

lib/AccessCheck/App/Step3.pm

@@ -20,9 +20,9 @@ sub run {
     my $config = $app->config();
     my $log    = $app->log();
 
-    $self->init_l10n();
-    $self->init_user();
-    $self->init_db();
+    my $l10n = $self->init_l10n();
+    my $user = $self->init_user();
+    my $db   = $self->init_db();
 
     if ($config->{app}->{login_url}) {
         return if !$self->check_authentication();
@@ -30,9 +30,6 @@ sub run {
 
     my $entityid = $self->param('entityid');
     my $email    = $self->param('email');
-    my $l10n     = $self->stash('l10n');
-    my $user     = $self->stash('user');
-    my $db       = $self->stash('db');
 
     my $sp = $self->get_sp(entityid => $entityid);
     return if !$sp;

lib/AccessCheck/App/Step4.pm

@@ -20,9 +20,9 @@ sub run {
     my $config = $app->config();
     my $log    = $app->log();
 
-    $self->init_l10n();
-    $self->init_user();
-    $self->init_db();
+    my $l10n = $self->init_l10n();
+    my $user = $self->init_user();
+    my $db   = $self->init_db();
 
     if ($config->{app}->{login_url}) {
         return if !$self->check_authentication();
@@ -33,8 +33,6 @@ sub run {
     my $token    = $self->param('token');
     my $validity = $self->param('validity');
     my $profiles = $self->every_param('profiles');
-    my $l10n     = $self->stash('l10n');
-    my $db       = $self->stash('db');
 
     my $sp = $self->get_sp(entityid => $entityid);
     return if !$sp;

lib/AccessCheck/App/Step5.pm

@@ -19,9 +19,9 @@ sub run {
     my $config = $app->config();
     my $log    = $app->log();
 
-    $self->init_l10n();
-    $self->init_user();
-    $self->init_db();
+    my $l10n = $self->init_l10n();
+    my $user = $self->init_user();
+    my $db   = $self->init_db();
 
     if ($config->{app}->{login_url}) {
         return if !$self->check_authentication();
@@ -30,7 +30,6 @@ sub run {
     my $entityid = $self->param('entityid');
     my $token    = $self->param('token');
     my $key      = $self->param('key');
-    my $db       = $self->stash('db');
 
     return if !$self->check_token(token => $token, entityid => $entityid);