use List::MoreUtils::any

lib/IdPAccountManager/Data/ServiceProvider.pm

@@ -5,6 +5,8 @@ use warnings;
 
 use base 'IdPAccountManager::DB::Object';
 
+use List::MoreUtils qw(any);
+
 __PACKAGE__->meta->setup(
     table   => 'serviceproviders',
 
@@ -33,17 +35,13 @@ sub print {
       join(',', $self->contacts());
 }
 
-## Check if email address is a known contact (or conf.dev_sp_contact)
+## Check if email address is a known contact
 sub is_contact {
     my ($self, $email) = @_;
 
     $email = lc($email);
 
-    foreach my $contact ($self->contacts()) {
-        return 1 if $email eq lc($contact);
-    }
-
-    return 0;
+    return any { $email eq lc($_) } $self->contacts();
 }
 
 1;