diff --git a/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java b/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java index 1bc1b8fc42e8ee5455f6b44b3a27f8bf689f9e6c..e8ad91d3b1e00e18cda868abf2aeb97f8595904e 100644 --- a/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java +++ b/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java @@ -510,9 +510,8 @@ public class DomainServiceImpl implements DomainService { @Override public void deleteAnnotation(Long id) { - if(this.domainAnnotationsRepository.findById(id).isPresent()){ - this.domainAnnotationsRepository.delete(this.domainAnnotationsRepository.findById(id).get()); - } + Optional<DomainAnnotation> domainFromDb = this.domainAnnotationsRepository.findById(id); + domainFromDb.ifPresent(this.domainAnnotationsRepository::delete); } @Override @@ -522,8 +521,9 @@ public class DomainServiceImpl implements DomainService { @Override public void updateAnnotation(Long id, DomainAnnotation annotation) { - if (this.domainAnnotationsRepository.findById(id).isPresent() && id.equals(annotation.getId())) { - DomainAnnotation domainAnnotation = this.domainAnnotationsRepository.findById(id).get(); + Optional<DomainAnnotation> domainFromDb = this.domainAnnotationsRepository.findById(id); + if (domainFromDb.isPresent() && id.equals(annotation.getId())) { + DomainAnnotation domainAnnotation = domainFromDb.get(); domainAnnotation.setKey(annotation.getKey()); domainAnnotation.setValue(annotation.getValue()); this.domainAnnotationsRepository.save(annotation);