diff --git a/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java b/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java index cf2c3700606b1a21b309a7b5c0b238ff7db3dfe2..1bfa4f3532b411f3594e5224616a4a6383dc9f07 100644 --- a/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java +++ b/src/main/java/net/geant/nmaas/portal/service/impl/DomainServiceImpl.java @@ -511,9 +511,8 @@ public class DomainServiceImpl implements DomainService { @Override public void deleteAnnotation(Long id) { - if(this.domainAnnotationsRepository.findById(id).isPresent()){ - this.domainAnnotationsRepository.delete(this.domainAnnotationsRepository.findById(id).get()); - } + Optional<DomainAnnotation> domainFromDb = this.domainAnnotationsRepository.findById(id); + domainFromDb.ifPresent(this.domainAnnotationsRepository::delete); } @Override @@ -523,8 +522,9 @@ public class DomainServiceImpl implements DomainService { @Override public void updateAnnotation(Long id, DomainAnnotationView annotation) { - if (this.domainAnnotationsRepository.findById(id).isPresent() && id.equals(annotation.getId())) { - DomainAnnotation domainAnnotation = this.domainAnnotationsRepository.findById(id).get(); + Optional<DomainAnnotation> domainFromDb = this.domainAnnotationsRepository.findById(id); + if (domainFromDb.isPresent() && id.equals(annotation.getId())) { + DomainAnnotation domainAnnotation = domainFromDb.get(); domainAnnotation.setKey(annotation.getKey()); domainAnnotation.setValue(annotation.getValue()); this.domainAnnotationsRepository.save(domainAnnotation);