From 9f35bd16161c276587eaf4c7ca160e698b230865 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Bie=C5=84?= <michal1.bien@gmail.com>
Date: Thu, 4 Apr 2019 16:17:25 +0200
Subject: [PATCH] fix 4 for janitor tests part 6
---
pkg/service/v1/config-service_test.go | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/pkg/service/v1/config-service_test.go b/pkg/service/v1/config-service_test.go
index c01b94e..49d62aa 100644
--- a/pkg/service/v1/config-service_test.go
+++ b/pkg/service/v1/config-service_test.go
@@ -223,20 +223,20 @@ func TestConfigServiceServer_DeleteIfExists(t *testing.T) {
ns.Name = "test-namespace"
_, _ = client.CoreV1().Namespaces().Create(&ns)
- //Should fail on configmap check
+ //Should return ok on configmap check if missing
res, err = server.DeleteIfExists(context.Background(), &req)
- if err == nil || res.Status != v1.Status_FAILED {
+ if err == nil || res.Status != v1.Status_OK {
+ t.Fail()
+ }
+
+ //create mock configmap
+ cm := corev1.ConfigMap{}
+ cm.Name = "test-uid"
+ _, _ = client.CoreV1().ConfigMaps("test-namespace").Create(&cm)
+
+ //should pass on deleting existing configmap
+ res, err = server.DeleteIfExists(context.Background(), &req)
+ if err != nil || res.Status != v1.Status_OK {
t.Fail()
}
- //
- ////create mock configmap
- //cm := corev1.ConfigMap{}
- //cm.Name = "test-uid"
- //_, _ = client.CoreV1().ConfigMaps("test-namespace").Create(&cm)
- //
- ////should pass
- //res, err = server.DeleteIfExists(context.Background(), &req)
- //if err != nil || res.Status != v1.Status_OK {
- // t.Fail()
- //}
}
\ No newline at end of file
--
GitLab