From 0ccdca31166db91b7b0261ad20de85b17fbf2653 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Tue, 31 Oct 2023 10:25:40 +0100
Subject: [PATCH] move api timeout to a static variable in config.py
---
lso/config.py | 1 +
lso/playbook.py | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lso/config.py b/lso/config.py
index ac734cc..bfb2b5e 100644
--- a/lso/config.py
+++ b/lso/config.py
@@ -19,6 +19,7 @@ CONFIG_SCHEMA = {
"required": ["ansible_playbooks_root_dir"],
"additionalProperties": False,
}
+DEFAULT_REQUEST_TIMEOUT = 10
class Config(BaseModel):
diff --git a/lso/playbook.py b/lso/playbook.py
index d985170..980c397 100644
--- a/lso/playbook.py
+++ b/lso/playbook.py
@@ -12,6 +12,8 @@ import xmltodict
from dictdiffer import diff
from pydantic import BaseModel, HttpUrl
+from lso.config import DEFAULT_REQUEST_TIMEOUT
+
logger = logging.getLogger(__name__)
@@ -153,7 +155,7 @@ def _run_playbook_proc(job_id: str, playbook_path: str, extra_vars: dict, invent
"return_code": int(ansible_playbook_run.rc),
}
- request_result = requests.post(callback, json=payload, timeout=10000)
+ request_result = requests.post(callback, json=payload, timeout=DEFAULT_REQUEST_TIMEOUT)
assert request_result.status_code == 200
--
GitLab