From 0f14760a5a895df619911443dd5b268ea63ee1be Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Wed, 14 May 2025 14:10:16 +0200
Subject: [PATCH] Don't run edge port validation on Juniper routers
---
gso/workflows/edge_port/validate_edge_port.py | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/gso/workflows/edge_port/validate_edge_port.py b/gso/workflows/edge_port/validate_edge_port.py
index 33b882a65..4aec9471f 100644
--- a/gso/workflows/edge_port/validate_edge_port.py
+++ b/gso/workflows/edge_port/validate_edge_port.py
@@ -78,21 +78,22 @@ def verify_base_config(subscription: dict[str, Any]) -> LSOState:
"Validate Edge Port Configuration", target=Target.SYSTEM, initial_input_form=wrap_modify_initial_input_form(None)
)
def validate_edge_port() -> StepList:
- """Validate an existing, active Edge port subscription.
+ """Validate an existing, active Edge port subscription if it is on a Nokia device.
- * Check correct configuration of interfaces in NetBox, only when the Edge Port is on a Nokia device.
+ * Check correct configuration of interfaces in NetBox.
* Verify create Edge port configuration.
"""
- edge_port_is_on_nokia = conditional(
- lambda state: state["subscription"]["edge_port"]["node"]["vendor"] == Vendor.NOKIA
+ edge_port_is_on_juniper = conditional(
+ lambda state: state["subscription"]["edge_port"]["node"]["vendor"] == Vendor.JUNIPER
)
return (
begin
>> store_process_subscription(Target.SYSTEM)
- >> unsync
>> prepare_state
- >> edge_port_is_on_nokia(verify_netbox_entries)
+ >> edge_port_is_on_juniper(done)
+ >> unsync
+ >> verify_netbox_entries
>> anonymous_lso_interaction(verify_base_config)
>> resync
>> done
--
GitLab