diff --git a/gso/services/netbox_client.py b/gso/services/netbox_client.py index 9a9d65e042ed7b2823a2a7bc17f1ee3f8ca36483..2fb397af09843b5f308eaa8991b46f1220abcf5a 100644 --- a/gso/services/netbox_client.py +++ b/gso/services/netbox_client.py @@ -145,7 +145,7 @@ class NetboxClient: """Create a new device in Netbox.""" # Get device type id - tier_info = TierInfo().get_module_by_name(f"Tier{site_tier}") + tier_info = TierInfo().get_module_by_name(f"tier{site_tier}") device_type = self.netbox.dcim.device_types.get(model=tier_info.device_type) # Get device role id @@ -261,7 +261,6 @@ class NetboxClient: ): interface.lag = None interface.save() - return def get_available_lags(self, router_id: UUID) -> list[str]: """Return all available :term:`LAG`s not assigned to a device.""" diff --git a/gso/utils/device_info.py b/gso/utils/device_info.py index 5a139889229efd80918e45079c805f18461e9dbb..15eaa6220d0cd4ba1247cb0911d27227274c3f8b 100644 --- a/gso/utils/device_info.py +++ b/gso/utils/device_info.py @@ -11,14 +11,14 @@ class ModuleInfo(BaseModel): class TierInfo: def __init__(self) -> None: - self.Tier1 = ModuleInfo( + self.tier1 = ModuleInfo( device_type="7750 SR-7s", module_bays_slots=[1, 2], module_type="XMA2-s-36p-400g", breakout_interfaces_per_slot=[36, 35, 34, 33], total_10g_interfaces=80, ) - self.Tier2 = ModuleInfo( + self.tier2 = ModuleInfo( device_type="7750-SR7s", module_bays_slots=[1, 2], module_type="XMA2-s-36p-400g", diff --git a/gso/workflows/iptrunk/migrate_iptrunk.py b/gso/workflows/iptrunk/migrate_iptrunk.py index 0d238437f4ec9f8016c0e693be1ea8fd201c13ff..596a4399c95b0ded27b43cb961907d34bbbc60e6 100644 --- a/gso/workflows/iptrunk/migrate_iptrunk.py +++ b/gso/workflows/iptrunk/migrate_iptrunk.py @@ -35,6 +35,8 @@ from gso.utils.helpers import ( logger = getLogger(__name__) +PLAYBOOK_VERB_NOT_YET_PROPERLY_SET = "Playbook verb is not yet properly set." + def initial_input_form_generator(subscription_id: UUIDstr) -> FormGenerator: subscription = Iptrunk.from_subscription(subscription_id) @@ -232,7 +234,7 @@ def deploy_new_config_dry( "trunk_interface", ) - logger.warning("Playbook verb is not yet properly set.") + logger.warning(PLAYBOOK_VERB_NOT_YET_PROPERLY_SET) return { "subscription": subscription, @@ -264,7 +266,7 @@ def deploy_new_config_real( False, ) - logger.warning("Playbook verb is not yet properly set.") + logger.warning(PLAYBOOK_VERB_NOT_YET_PROPERLY_SET) return { "subscription": subscription, @@ -315,7 +317,7 @@ def deploy_new_isis( False, ) - logger.warning("Playbook verb is not yet properly set.") + logger.warning(PLAYBOOK_VERB_NOT_YET_PROPERLY_SET) return { "subscription": subscription, @@ -371,7 +373,7 @@ def delete_old_config_dry( "delete", ) - logger.warning("Playbook verb is not yet properly set.") + logger.warning(PLAYBOOK_VERB_NOT_YET_PROPERLY_SET) return {"subscription": subscription} @@ -401,7 +403,7 @@ def delete_old_config_real( False, ) - logger.warning("Playbook verb is not yet properly set.") + logger.warning(PLAYBOOK_VERB_NOT_YET_PROPERLY_SET) return {"subscription": subscription}