From c193e290de0d31a6680fca4014183b542c7fc976 Mon Sep 17 00:00:00 2001 From: Neda Moeini <neda.moeini@geant.org> Date: Thu, 7 Dec 2023 09:47:34 +0100 Subject: [PATCH] Fixed typo. --- test/conftest.py | 2 +- test/workflows/iptrunk/test_create_iptrunk.py | 3 +-- test/workflows/iptrunk/test_modify_trunk_interface.py | 8 ++++---- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/test/conftest.py b/test/conftest.py index ff7784da..4475914b 100644 --- a/test/conftest.py +++ b/test/conftest.py @@ -83,7 +83,7 @@ class FakerProvider(BaseProvider): def network_interface(self) -> str: return self.generator.numerify("ge-@#/@#/@#") - def generate_junniper_members_list(self) -> list[LAGMember]: + def generate_juniper_members_list(self) -> list[LAGMember]: iface_amount = self.generator.random_int(min=2, max=5) interface_names = [f"{prefix}{i}" for prefix in ["xe-1/0/", "ge-3/0/", "xe-2/1/"] for i in range(iface_amount)] return [ diff --git a/test/workflows/iptrunk/test_create_iptrunk.py b/test/workflows/iptrunk/test_create_iptrunk.py index fa5292f7..fd5da666 100644 --- a/test/workflows/iptrunk/test_create_iptrunk.py +++ b/test/workflows/iptrunk/test_create_iptrunk.py @@ -46,12 +46,11 @@ def _netbox_client_mock(): def input_form_wizard_data(request, juniper_router_subscription_factory, nokia_router_subscription_factory, faker): vendor = getattr(request, "param", RouterVendor.NOKIA) router_side_a = nokia_router_subscription_factory() - side_b_members = None # Set side b router to Juniper if vendor == RouterVendor.JUNIPER: router_side_b = juniper_router_subscription_factory() - side_b_members = faker.generate_junniper_members_list() + side_b_members = faker.generate_juniper_members_list() else: router_side_b = nokia_router_subscription_factory() side_b_members = [ diff --git a/test/workflows/iptrunk/test_modify_trunk_interface.py b/test/workflows/iptrunk/test_modify_trunk_interface.py index bb83572d..713bf5c6 100644 --- a/test/workflows/iptrunk/test_modify_trunk_interface.py +++ b/test/workflows/iptrunk/test_modify_trunk_interface.py @@ -29,21 +29,21 @@ def input_form_iptrunk_data( side_node = juniper_router_subscription_factory() side_a_node = iptrunk_side_subscription_factory(iptrunk_side_node=side_node) side_b_node = iptrunk_side_subscription_factory() - new_side_a_ae_members = faker.generate_junniper_members_list() + new_side_a_ae_members = faker.generate_juniper_members_list() new_side_b_ae_members = faker.generate_nokia_members_list() elif use_juniper == UseJuniperSide.SIDE_B: side_node = juniper_router_subscription_factory() side_a_node = iptrunk_side_subscription_factory() side_b_node = iptrunk_side_subscription_factory(iptrunk_side_node=side_node) new_side_a_ae_members = faker.generate_nokia_members_list() - new_side_b_ae_members = faker.generate_junniper_members_list() + new_side_b_ae_members = faker.generate_juniper_members_list() elif use_juniper == UseJuniperSide.SIDE_BOTH: side_node_1 = juniper_router_subscription_factory() side_node_2 = juniper_router_subscription_factory() side_a_node = iptrunk_side_subscription_factory(iptrunk_side_node=side_node_1) side_b_node = iptrunk_side_subscription_factory(iptrunk_side_node=side_node_2) - new_side_a_ae_members = faker.generate_junniper_members_list() - new_side_b_ae_members = faker.generate_junniper_members_list() + new_side_a_ae_members = faker.generate_juniper_members_list() + new_side_b_ae_members = faker.generate_juniper_members_list() else: side_a_node = iptrunk_side_subscription_factory() side_b_node = iptrunk_side_subscription_factory() -- GitLab